[core] Make zlib a builtin obtained from the web and remove the vendored code#21653
Draft
dpiparo wants to merge 2 commits intoroot-project:masterfrom
Draft
[core] Make zlib a builtin obtained from the web and remove the vendored code#21653dpiparo wants to merge 2 commits intoroot-project:masterfrom
dpiparo wants to merge 2 commits intoroot-project:masterfrom
Conversation
Test Results 20 files 20 suites 2d 20h 35m 27s ⏱️ For more details on these failures, see this check. Results for commit c51b186. ♻️ This comment has been updated with latest results. |
And simplify the way it is included in Core, by replicating what is done for lzma. The version of zlib is zlib-ng 1.3.2
dpiparo
force-pushed
the
builtin_zlib_v2
branch
from
c51b186 to
73bbc81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does what was done for lzma by #21571.
The ZLib fetched is version 1.3.2 from LCG, and treated as lzma (and libpng, libgif and libjpeg, and others). Moreover, a dependency to it in builtin libpng had to be added.