Skip to content

RateLimiter: Don't update parameters before input checks #437 (backport #554)#594

Merged
christophfroehlich merged 1 commit intokiltedfrom
mergify/bp/kilted/pr-554
Apr 13, 2026
Merged

RateLimiter: Don't update parameters before input checks #437 (backport #554)#594
christophfroehlich merged 1 commit intokiltedfrom
mergify/bp/kilted/pr-554

Conversation

@mergify
Copy link
Copy Markdown

@mergify mergify bot commented Apr 13, 2026

Fixed issue #437. I submitted two pull requests: one in the ros2_controllers repository and another in the control_toolbox repository.
The current PR resolves the following issues:

  1. Modified the logic of RateLimiter::set_params to prevent the original parameters from being modified before an exception is thrown. This change allows exceptions thrown by set_params to be caught by the caller.
    This is an automatic backport of pull request RateLimiter: Don't update parameters before input checks #437 #554 done by Mergify.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.85714% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.79%. Comparing base (a7a19cc) to head (dcd8937).

Files with missing lines Patch % Lines
...l_toolbox/include/control_toolbox/rate_limiter.hpp 62.85% 0 Missing and 13 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           kilted     #594      +/-   ##
==========================================
+ Coverage   82.74%   82.79%   +0.05%     
==========================================
  Files          29       29              
  Lines        1999     2005       +6     
  Branches      110      110              
==========================================
+ Hits         1654     1660       +6     
  Misses        276      276              
  Partials       69       69              
Flag Coverage Δ
unittests 82.79% <62.85%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...l_toolbox/include/control_toolbox/rate_limiter.hpp 75.36% <62.85%> (+2.34%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit e827b12 into kilted Apr 13, 2026
13 of 14 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/kilted/pr-554 branch April 13, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants