Fix source mapping so backtraces report original file paths#11
Merged
JPDuchesne merged 1 commit intomasterfrom Feb 25, 2026
Merged
Fix source mapping so backtraces report original file paths#11JPDuchesne merged 1 commit intomasterfrom
JPDuchesne merged 1 commit intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
JPDuchesne
force-pushed
the
jpd/source-mapping-fix
branch
from
22c13f4 to
394bc7c
Compare
- Compile ISeq with original source_path instead of tmp/ rewritten path - Register source maps by both transformed and source file paths - Use File.binread for transform! detection to avoid encoding issues in locale-less environments (CI, containers) Co-authored-by: Cursor <cursoragent@cursor.com>
JPDuchesne
force-pushed
the
jpd/source-mapping-fix
branch
from
394bc7c to
e65a92c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RubyVM::InstructionSequencewith the originalsource_pathinstead of thetmp/rewritten path, socallerand backtrace entries reference the real source fileBacktraceFilter) can look up mappings by either keyFile.read+ regex withFile.binread+String#include?for thetransform!fast-path check — avoids encoding errors in locale-less environments (CI containers, sandboxes) whereEncoding.default_externalis US-ASCII; downstream (Prism, ISeq compiler) handle encoding natively via magic commentsTest plan
source map is retrievable by source file pathcompiled iseq reports original source pathbinreadwithinclude?handles non-ASCII contentMade with Cursor