Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses an issue related to HTML fragments and the inclusion of bundler information in the output. It streamlines generated JavaScript bundles by removing specific Rspack runtime modules ( Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces two main changes. First, it appears to fix an issue in HtmlWebpackPlugin where HTML fragments in templateContent were not handled as expected, and a test in html-plugin/basic.test.js is updated accordingly. Second, it disables bundler information for the css-extract/cases/prefetch-preload test case by setting output.bundlerInfo: false in the webpack configuration, which is reflected in the updated expected output file. The changes look correct. I have one suggestion to make the test assertion more precise.
| [` | ||
| <html> | ||
| <head></head><body><span>Rspack</span><span>Rspack</span></body></html>`], null); | ||
| [`<span>Rspack</span><span>Rspack</span>`], null); |
There was a problem hiding this comment.
Using toContain is a bit loose for this test. Given the PR title "fix: html fragment", it seems the goal is for the output to be exactly the provided fragment. To make this test more robust and prevent future regressions where the fragment might be unintentionally wrapped in other HTML, I recommend using a regular expression with start (^) and end ($) anchors. This will ensure the output is exactly the expected fragment and nothing more.
| [`<span>Rspack</span><span>Rspack</span>`], null); | |
| [/^<span>Rspack<\/span><span>Rspack<\/span>$/], null); |
1 participant
No description provided.