fix: avoid autotools regeneration when building bundled libuv#431
Closed
Copilot wants to merge 1 commit intofix/libuv-autotools-buildfrom
Closed
fix: avoid autotools regeneration when building bundled libuv#431Copilot wants to merge 1 commit intofix/libuv-autotools-buildfrom
Copilot wants to merge 1 commit intofix/libuv-autotools-buildfrom
Conversation
|
|
Copilot
AI
changed the title
[WIP] Fix issue with autogen.sh during libuv build
fix: avoid autotools regeneration when building bundled libuv
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CRAN
r-devel-macos-arm64is failing to installhttpuvbecause the bundled libuv build conditionally runsautoupdate/autogen.shwhenautomakeis present, even if the rest of the autotools toolchain is missing or version-mismatched. The vendored libuv sources already include the generated autotools artifacts needed at build time, so regeneration is both unnecessary and fragile.Root cause
src/Makevars.intreatedautomakeonPATHas a signal to fully regenerate libuv build files.autogen.shdue to missing companion tools (glibtoolize, matchingaclocal, etc.).Change
automakedetection branch fromsrc/Makevars.in../configure.Effect
configure,Makefile.in, andaclocal.m4.Updated build flow
Why this is the right scope
Makevars.inwith the documented libuv update flow: generate autotools files when updating the vendored source, not when installing the package.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.