Fix rank_list bindings for modules#129
Open
bschiffthaler wants to merge 1 commit intorstudio:mainfrom
Open
Conversation
Author
|
Sorry for the duplicate of the previous PR. It had the wrong email for one of the commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed an issue where update_rank_list() did not work within the context of a shiny module, despite using the recent updates and calling enable_modules(). The Shiny JS binding for setValue was still looking for a prefix-based pattern to actually update the DOM. I believe this fix enables the function irrespective of the shiny context (module or not).
This might also address #122