fix: coerce Encryptor::decrypt() to string#76
Merged
justlevine merged 1 commit intodevelopfrom Jan 27, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Ensures Settings::get_api_key() always returns a string even when decryption fails (e.g., legacy/invalid stored keys), avoiding type errors under strict_types.
Changes:
- Coerce the decrypted API key result to a string-safe return value in
Settings::get_api_key(). - Simplify
Settings::regenerate_api_key()to return the generated key directly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
up1512001
approved these changes
Jan 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ensures Settings::get_api_key() returns a string even if decryption fails - e.g. from a legacy key.
Why
Fixes a regression in #71 where the string coersion wasn't appl
Related Issue(s):
How
Testing Instructions
Screenshots
Additional Info
Checklist