fix(rewrite): skip unsupported find predicates#676
fix(rewrite): skip unsupported find predicates#676TechWizard9999 wants to merge 1 commit intortk-ai:developfrom
Conversation
5a6ebac to
550d7d3
Compare
|
@pszymkowiak could you please review this and let me know if anything needs to change? |
|
Hey We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes No logic changes — only file moves and import path updates. What you need to doRebase your branch on git fetch origin && git rebase origin/developGit detects renames automatically. If you get import conflicts, update the paths: use crate::git; // now: use crate::cmds::git::git;
use crate::tracking; // now: use crate::core::tracking;
use crate::config; // now: use crate::core::config;
use crate::init; // now: use crate::hooks::init;
use crate::gain; // now: use crate::analytics::gain;Need help rebasing? Tag @aeppling |
550d7d3 to
c6db1d9
Compare
|
Rebased on latest develop per the refactor notice and force-updated this branch. @pszymkowiak could you please re-review when convenient? |
c6db1d9 to
ef00665
Compare
Signed-off-by: Roopesh <roopesh1724989@gmail.com>
ef00665 to
df6674f
Compare
|
Rebased on latest develop and force-pushed with conflict resolution.\n\nRetested the unsupported find predicate behavior included in this PR.\n\n@pszymkowiak @FlorianBruniaux please re-review when convenient. |
|
Quick maintainer ping after rebase and validation rerun. @pszymkowiak @FlorianBruniaux please re-review when convenient. |
|
@aeppling @pszymkowiak @FlorianBruniaux kindly merge this? |
Description
Fix rewrite behavior for
findcommands that use unsupported compound predicates/actions. Instead of rewriting those tortk find(which then errors), we now pass them through as nativefind.Related Issue
Closes #664
Changes Made
find-not,-exec,-execdir,-ok,-okdir,-delete,-prune,-fls,-fprint,-fprintf,-quit-notand-execFiles Changed
src/discover/registry.rs- rewrite guard + testsCHANGELOG.md- unreleased bug-fix note for Error: rtk find does not support compound predicates or actions #664Testing
cargo fmt --all --checkrtk cargo clippy --all-targets(2 pre-existing warnings in untouched files)rtk cargo testrtk cargo test discover::registry::tests::test_rewrite_find_skips_unsupported_notrtk cargo test discover::registry::tests::test_rewrite_find_skips_unsupported_execChecklist
cc @pszymkowiak for review