Skip to content

fix(cargo): show clippy error details in compact output#677

Merged
FlorianBruniaux merged 1 commit intortk-ai:developfrom
TechWizard9999:fix/cargo-clippy-show-error-details
Mar 28, 2026
Merged

fix(cargo): show clippy error details in compact output#677
FlorianBruniaux merged 1 commit intortk-ai:developfrom
TechWizard9999:fix/cargo-clippy-show-error-details

Conversation

@TechWizard9999
Copy link
Copy Markdown
Contributor

Description

rtk cargo clippy could collapse output to counts/rules while hiding actionable error text in some failure modes. This PR preserves concise output but always includes concrete error lines.

Related Issue

Closes #602

Changes Made

  • enhanced clippy filter to collect and show error detail lines in compact output
  • added an Error details section (up to 5 entries, with overflow summary)
  • added regression test to ensure error text is present when clippy reports an error
  • added changelog entry under Unreleased bug fixes

Files Changed

Testing

  • cargo fmt --all --check
  • rtk cargo clippy --all-targets (2 pre-existing warnings in untouched files)
  • rtk cargo test
  • rtk cargo test cargo_cmd::tests::test_filter_cargo_clippy_includes_error_details

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Documentation updated
  • No breaking changes introduced

cc @pszymkowiak for review

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 20, 2026

CLA assistant check
All committers have signed the CLA.

@TechWizard9999
Copy link
Copy Markdown
Contributor Author

@pszymkowiak could you please review this and let me know if anything needs to change?

@aeppling
Copy link
Copy Markdown
Contributor

Hey

We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes src/ from a flat layout into subfolders.

No logic changes — only file moves and import path updates.

What you need to do

Rebase your branch on develop when receiving this comment:

git fetch origin && git rebase origin/develop

Git detects renames automatically. If you get import conflicts, update the paths:

use crate::git;        // now: use crate::cmds::git::git;
use crate::tracking;   // now: use crate::core::tracking;
use crate::config;     // now: use crate::core::config;
use crate::init;       // now: use crate::hooks::init;
use crate::gain;       // now: use crate::analytics::gain;

Need help rebasing? Tag @aeppling

Signed-off-by: Roopesh <roopesh1724989@gmail.com>
@TechWizard9999 TechWizard9999 force-pushed the fix/cargo-clippy-show-error-details branch from 43ea1f5 to def3424 Compare March 27, 2026 01:48
@TechWizard9999
Copy link
Copy Markdown
Contributor Author

Rebased on latest develop per the refactor notice and force-updated this branch.

@pszymkowiak could you please re-review when convenient?

@FlorianBruniaux FlorianBruniaux merged commit a0d6874 into rtk-ai:develop Mar 28, 2026
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants