fix(cargo): preserve clippy -- separator with cargo flags#679
fix(cargo): preserve clippy -- separator with cargo flags#679TechWizard9999 wants to merge 1 commit intortk-ai:developfrom
Conversation
f3c0da3 to
80d643e
Compare
|
@pszymkowiak could you please review this and let me know if anything needs to change? |
|
Hey We are cleaning up the codebase and improving the project structure for better onboarding. As part of this effort, PR #826 reorganizes No logic changes — only file moves and import path updates. What you need to doRebase your branch on git fetch origin && git rebase origin/developGit detects renames automatically. If you get import conflicts, update the paths: use crate::git; // now: use crate::cmds::git::git;
use crate::tracking; // now: use crate::core::tracking;
use crate::config; // now: use crate::core::config;
use crate::init; // now: use crate::hooks::init;
use crate::gain; // now: use crate::analytics::gain;Need help rebasing? Tag @aeppling |
80d643e to
925b44b
Compare
|
Rebased on latest develop per the refactor notice and force-updated this branch. @pszymkowiak could you please re-review when convenient? |
925b44b to
027023e
Compare
Signed-off-by: Roopesh <roopesh1724989@gmail.com>
027023e to
dc29900
Compare
|
Rebased on latest develop and force-pushed to refresh this PR.\n\nI also re-ran the related cargo separator test locally.\n\n@pszymkowiak @FlorianBruniaux please re-review when convenient. |
|
Quick maintainer ping after rebase/refresh. @pszymkowiak @FlorianBruniaux please re-review when convenient. |
Description
Fixes
rtk cargo clippyargument reconstruction when cargo flags are present before--.Related Issue
Closes #660
Changes Made
--restoration logic to reconstruct the split point using ordered token matching (instead of broad containment counting)----all-targets -- -D warnings--workspace -- -D warningsFiles Changed
src/cargo_cmd.rsCHANGELOG.mdTesting
cargo fmt --all --checkrtk cargo clippy --all-targets(2 pre-existing warnings in untouched files)rtk cargo testrtk cargo test cargo_cmd::tests::test_restore_double_dash_clippy_with_all_targetsrtk cargo test cargo_cmd::tests::test_restore_double_dash_clippy_with_workspacecc @pszymkowiak for review