API.logger is confusing statement#1540
Open
greenfieldtech-davidb wants to merge 2 commits intoruby-grape:masterfrom
Open
API.logger is confusing statement#1540greenfieldtech-davidb wants to merge 2 commits intoruby-grape:masterfrom
greenfieldtech-davidb wants to merge 2 commits intoruby-grape:masterfrom
Conversation
It is confusing because it may look like `API` means `Grape::API`
Member
|
We mostly use TwitterAPI in the documentation, maybe we want to standardize on that everywhere? Care to review the rest of the readme? No need to edit CHANGELOG for this one if you don't feel like it, danger is being annoying :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is confusing because it may look like
APImeansGrape::API