Conversation
C: Convert if nested inside else to elsif.
|
Interesting. This feels like a workaround rather than a fix. Why wouldn't something like |
|
Hi @dblock the warnings occur because I did not look into implementation details, my objective was to clear three warnings that were showing in my projects specs, but since I'm here might as well fix them all 😄 Having warnings not suppressed has saved me from some bugs in the past, but it comes with the caveat of having to fix them if we want a sane output when running tests 😛 Would you like me to change something on the PR? |
|
Yes, lets have this discussion in hashie/hashie#416 first? Same problem but fewer changes. |
|
Thanks for your contribution. |
|
I want to revive this. I think a fix that says |
Hi all,
When running specs with warnings on, grape outputs a lot of warnings.
This PR attempts to fix all of them.
With regards to the warnings:
warning: instance variable @disable_warnings not initialized, by thehashiegem, I have opened a PR there to fix those: hashie/hashie#416