Report endpoint_call.grape which includes the whole stack#2021
Report endpoint_call.grape which includes the whole stack#2021Kukunin wants to merge 5 commits intoruby-grape:masterfrom
Conversation
|
Rubocop limit was increased previously too 28d34ee#diff-74423563ec7c74f4cb7f74689b49e7c1R47, and I believe to refactor it, a person should a better insight about grape than I have. So I increased limit by 3 lines too |
| #### endpoint_run.grape | ||
|
|
||
| The main execution of an endpoint, includes filters and rendering. | ||
| Similar to `endpoint_call.grape` but does not include middlewares, thus might be inaccurate. |
There was a problem hiding this comment.
I think "inaccurate" is incorrect. I think here we want to highlight what this does, as opposed to what it doesn't. Maybe "Execution of the endpoint, excluding filters, middlewares or execution inside rescue_from blocks." + explain what happens during an exception?
|
|
||
| The main execution of an endpoint, includes filters and rendering. | ||
| Similar to `endpoint_call.grape` but does not include middlewares, thus might be inaccurate. | ||
| One more difference that it returns original exceptions, before `rescue_from` handlers. |
There was a problem hiding this comment.
Should be part of the text above. But this is unclear. What does "returns" mean here?
|
Thanks for the review. Will try to fix the issues later today or tomorrow |
Version 1.6.2
|
@Kukunin bumping myself on top of your list! |
|
hi @dblock. do you mean that it'd be good to finalize and get this PR merged? If yes, then it's something I can do |
Yes, please! Rebase & al. I know it's old but I think we still want it. |
2 participants
Fixes #2010
To keep the backward compatibility, I introduced a new event. The integration works fine in my project with this change.