Merged
Conversation
Depends on #538, which drops support for ruby 3.1. This code would only run in ruby 3.1, so removing it is not be a breaking change. Please note: TruffleRuby and JRuby support for Data is incomplete, but the code doesn't currently distinguish between them and CRuby, so they're the same level of broken as before. We're keeping the Data tests, to help track full support in other ruby implementations. For now, we're keeping Net::IMAP::Data only to support YAML encoding. But the rest of the ::Data polyfill has been dropped. psych v5.2.5 handles Data natively, so DataLite will be dropped completely (in a separate PR).
nevans
force-pushed
the
drop-data-polyfill
branch
from
7d7d424 to
faa83d6
Compare
nevans
added
breaking-change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on #538, which drops support for ruby 3.1. This code would only run in ruby 3.1, so removing it is not a breaking change.
For now, we're keeping
Net::IMAP::Dataonly to support YAML encoding. But the rest of the::Datapolyfill has been dropped. psych v5.2.5 handlesDatanatively, soDataLitewill be dropped completely in #543.Please note: TruffleRuby and JRuby support for
Datais incomplete, but the code doesn't currently distinguish between them and CRuby, so they're the same level of broken as before. 😉 We're keeping theDatatests (for now), to help track full support in other ruby implementations.