[rust] add node_ext module with full_name methods for constant nodes#3887
Open
[rust] add node_ext module with full_name methods for constant nodes#3887
node_ext module with full_name methods for constant nodes#3887Conversation
node_ext module with full_name methods for constant nodesnode_ext module with full_name methods for constant nodes
Port Ruby's `node_ext.rb` functionality to Rust bindings, providing `full_name` and `full_name_parts` methods for `ConstantReadNode`, `ConstantWriteNode`, `ConstantTargetNode`, `ConstantPathNode`, and `ConstantPathTargetNode`. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ed95c4e to
f3f9590
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
node_ext.rbfunctionality to Rust bindingsfull_nameandfull_name_partsmethods forConstantReadNode,ConstantWriteNode,ConstantTargetNode,ConstantPathNode, andConstantPathTargetNodeConstantPathErrorenum for error handlingTest Coverage
Rust bindings include 11 unit tests compared to Ruby's 8 tests. Additional coverage includes:
ConstantWriteNode(not tested in Ruby)ConstantTargetNode(not tested in Ruby)MissingNodeserror case (not tested in Ruby)Public API Changes (cargo-public-api)
Test plan
bundle exec rake cargo:testpassesbundle exec rake cargo:lintpasses🤖 Generated with Claude Code