Conversation
Collaborator
kddnewton
commented
Mar 20, 2026
- Use rb_ary_store instead of rb_ary_push when the array is right-sized
- Put a cache for the constant pool on the parser since we re-hash the same bounds between the lexer and the parser (I actually would like to solve this differently, but for now it's like an 8% win)
- Lazily unpack the line offsets the first time they are accessed so if you are a Ruby API consumer that does not touch line numbers you don't pay for the array building
- Fast-path out of parse_arguments_list when a token cannot possibly start an argument.
- Use an arena for building the stack that builds the AST in Ruby
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.