Invoke initialize from Ruby, not native code#763
Closed
headius wants to merge 1 commit intoruby:masterfrom
Closed
Conversation
JRuby does not expose the `initialize` method for a given Data instance to native code, so there's no equivalent to calling `rb_struct_initialize`. This change moves that initialization to a Ruby `__send__` and removes the native stub method `init_data`. Fixes broken JRuby `Data` logic after ruby#692.
Member
|
This looks nice & simple but it will break for some Data classes as shown in item 1 of #764 (comment). |
Member
|
Let's merge #765 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JRuby does not expose the
initializemethod for a given Data instance to native code, so there's no equivalent to callingrb_struct_initialize. This change moves that initialization to a Ruby__send__and removes the native stub methodinit_data.Fixes broken JRuby
Datalogic after #692.