Skip to content

Fix test failure on Windows in ruby/ruby #2900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
soutaro merged 2 commits into from
Mar 25, 2026
+4 −4
Merged

Fix test failure on Windows in ruby/ruby #2900

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2a2bb9e
Use `echo` instead of `env` for Windows
soutaro Mar 25, 2026
7504ccd
unsetenv_others: false
soutaro Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/stdlib/Open3_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ def test_popen2
assert_send_type "(*::String) -> [ ::IO, ::IO, ::Process::Waiter ]",
Open3, :popen2, 'echo "Foo"'
assert_send_type "(*::String, unsetenv_others: bool) -> [ ::IO, ::IO, ::Process::Waiter ]",
Open3, :popen2, 'env', unsetenv_others: true
Open3, :popen2, 'echo "Foo"', unsetenv_others: false
assert_send_type "(*::String, close_others: bool) -> [ ::IO, ::IO, ::Process::Waiter ]",
Open3, :popen2, 'env', close_others: true
Open3, :popen2, 'echo "Foo"', close_others: true
assert_send_type "(*::String, chdir: ::String) -> [ ::IO, ::IO, ::Process::Waiter ]",
Open3, :popen2, 'echo "Foo"', chdir: '.'
assert_send_type "(::Hash[::String, ::String], ::String) -> [ ::IO, ::IO, ::Process::Waiter ]",
Expand All @@ -61,9 +61,9 @@ def test_popen3
assert_send_type "(::String) -> [ ::IO, ::IO, ::IO, ::Process::Waiter ]",
Open3, :popen3, 'echo "Foo"'
assert_send_type "(::String, unsetenv_others: bool) -> [ ::IO, ::IO, ::IO, ::Process::Waiter ]",
Open3, :popen3, 'env', unsetenv_others: true
Open3, :popen3, 'echo "Foo"', unsetenv_others: false
assert_send_type "(::String, close_others: bool) -> [ ::IO, ::IO, ::IO, ::Process::Waiter ]",
Open3, :popen3, 'env', close_others: true
Open3, :popen3, 'echo "Foo"', close_others: true
assert_send_type "(::String, chdir: ::String) -> [ ::IO, ::IO, ::IO, ::Process::Waiter ]",
Open3, :popen3, 'echo "Foo"', chdir: '.'
assert_send_type "(::Hash[::String, ::String], ::String) -> [ ::IO, ::IO, ::IO, ::Process::Waiter ]",
Expand Down
Loading