Precompile shipit assets before benchmark iterations#494
Closed
Precompile shipit assets before benchmark iterations#494
Conversation
The shipit-engine ships CoffeeScript assets that require a Node.js runtime to compile via Sprockets. Without precompilation, Sprockets shells out to Node.js on the first request during warmup/benchmark iterations, adding noise to timing measurements. Run assets:precompile once before any iterations, and skip it on subsequent runs by checking for the Sprockets manifest file. Fixes ruby#493
Member
|
#495 should make this unnecessarily. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shipit-engine ships CoffeeScript assets that require a Node.js runtime to compile via Sprockets. Without precompilation, Sprockets shells out to Node.js on the first request during warmup/benchmark iterations, adding noise to timing measurements.
Run assets:precompile once before any iterations, and skip it on subsequent runs by checking for the Sprockets manifest file.
Fixes #493