Merged
Conversation
2 tasks
e5f2dde to
58dc555
Compare
Allows users to specify a README template other than the default template currently defined in `packs`.
58dc555 to
68847d7
Compare
tstannard
reviewed
Dec 16, 2024
spec/packs_spec.rb
Outdated
| Packs.create_pack!(pack_name: 'packs/organisms') | ||
| ParsePackwerk.bust_cache! | ||
| actual_readme_todo = ParsePackwerk.find('packs/organisms').directory.join('README_TODO.md') | ||
| expect(actual_readme_todo.read).to eq 'This is the template' |
Contributor
There was a problem hiding this comment.
can you change the content to This is the custom template so that it's clear this test is testing something different from the one on 342
tstannard
approved these changes
Dec 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows users to specify a README template other than the default template currently defined in
packs. Also allows users to specify a path to the readme template, or by default the template should be located atREADME_TEMPLATE.md. The README_TODO file currently contains the following text:Some organizations may want to use their own README template. #154 requested the ability to customize the README but was closed due to inactivity.