Conversation
johnpaulashenfelter
added
language:ruby
bglusman
commented
Jul 30, 2023
bglusman
commented
Jul 30, 2023
bglusman
commented
Jul 30, 2023
Closed
Collaborator
|
Noting that running |
Contributor
|
I also made an attempt in PR #760 , check it out if you have a chance. I did it from scratch, going to look through this for bits I may have missed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tests were failing, one is fixed but in a way that may break some functionality, one is marked pending based on the error looking like it is meeting the expectation but ALSO failing in additional unexpected ways that... may be fine?