Remove the old position enum from affiliation

app/controllers/people_controller.rb

@@ -391,7 +391,6 @@ def person_params
       affiliations_attributes: [
         :id,
         :organization_id,
-        :position,
         :title,
         :inactive,
         :primary_contact,

app/decorators/person_decorator.rb

@@ -4,7 +4,7 @@ def title
   end
 
   def detail(length: nil)
-    text = affiliations.active.map { |affiliation| "#{affiliation.title.presence || affiliation.position}, #{affiliation.organization.name}" }.join(", ")
+    text = affiliations.active.map { |affiliation| "#{affiliation.title}, #{affiliation.organization.name}" }.join(", ")
     length ? text&.truncate(length) : text
   end
 

app/models/affiliation.rb

@@ -5,9 +5,6 @@ class Affiliation < ApplicationRecord
   # Validations
   validates_presence_of :organization_id
 
-  # Enum
-  enum :position, { default: 0, liaison: 1, leader: 2, assistant: 3 }
-
   scope :active, -> {
     where(inactive: false)
       .where("end_date IS NULL OR end_date >= ?", Date.current)

app/views/organizations/_affiliation_fields.html.erb

@@ -31,7 +31,7 @@
                     as: :text,
                     input_html: {
                       rows: 1,
-                      value: f.object&.title || f.object&.position || "Facilitator",
+                      value: f.object&.title || "Facilitator",
                       style: "height: 42px; min-height: 42px;",
                       data: {
                         inactive_toggle_target: "title",
@@ -83,6 +83,6 @@
   </div>
 <% else %>
   <div class="ps-6 mb-4">
-    <li><%= f.object.organization&.name %> (<%= f.object.title || f.object.position %>)</li>
+    <li><%= f.object.organization&.name %> (<%= f.object.title %>)</li>
   </div>
 <% end %>

app/views/organizations/_form.html.erb

@@ -318,7 +318,7 @@
       <% else %>
         <% f.object.user&.person&.affiliations&.each do |affiliation| %>
           <div class="ps-6 mb-2">
-            <li><%= affiliation.title || affiliation.position %> - <%= person_profile_button(affiliation.user.person, subtitle: (affiliation.user.person.preferred_email if affiliation.user.person.profile_show_email? || allowed_to?(:manage?, Person))) if affiliation.persisted? && affiliation.user.person %></li>
+            <li><%= affiliation.title %> - <%= person_profile_button(affiliation.user.person, subtitle: (affiliation.user.person.preferred_email if affiliation.user.person.profile_show_email? || allowed_to?(:manage?, Person))) if affiliation.persisted? && affiliation.user.person %></li>
           </div>
         <% end %>
       <% end %>

app/views/people/_affiliation_fields.html.erb

@@ -32,7 +32,7 @@
                       as: :text,
                       input_html: {
                         rows: 1,
-                        value: f.object.title || f.object.position || "Facilitator",
+                        value: f.object.title || "Facilitator",
                         style: "height: 42px; min-height: 42px;",
                         data: {
                           inactive_toggle_target: "title",
@@ -85,6 +85,6 @@
   </div>
 <% else %>
   <div class="ps-6 mb-4">
-    <li><%= f.object.organization&.name %> (<%= f.object.title || f.object.position %>)</li>
+    <li><%= f.object.organization&.name %> (<%= f.object.title %>)</li>
   </div>
 <% end %>

app/views/people/_form.html.erb

@@ -273,7 +273,7 @@
       <% else %>
         <% f.object.affiliations.each do |affiliation| %>
           <div class="ps-6 mb-2">
-            <li><%= affiliation.title || affiliation.position %> - <%= affiliation.persisted? ? (link_to affiliation.organization&.name, organization_path(affiliation.organization), class: "underline") : affiliation.organization&.name %></li>
+            <li><%= affiliation.title %> - <%= affiliation.persisted? ? (link_to affiliation.organization&.name, organization_path(affiliation.organization), class: "underline") : affiliation.organization&.name %></li>
           </div>
         <% end %>
       <% end %>

app/views/users/_affiliation_fields.html.erb

@@ -17,7 +17,7 @@
                   as: :text,
                   input_html: {
                     rows: 1,
-                    value: f.object.title || f.object.position,
+                    value: f.object.title,
                   } %>
     </div>
 

spec/factories/affiliations.rb

@@ -3,6 +3,6 @@
     association :organization
     association :person
 
-    position { :default }
+    title { "Facilitator" }
   end
 end

spec/models/affiliation_spec.rb

@@ -14,10 +14,6 @@
     # it { should validate_presence_of(:person_id) } # we needed to not have this to support nested attrs
   end
 
-  describe 'enums' do
-    it { should define_enum_for(:position).with_values(default: 0, liaison: 1, leader: 2, assistant: 3) }
-  end
-
   describe '.active' do
     let!(:active_op) { create(:affiliation, inactive: false, end_date: nil) }
     let!(:active_with_future_end) { create(:affiliation, inactive: false, end_date: 1.month.from_now) }