Conversation
| import "@rails/activestorage" | ||
| import * as ActiveStorage from "@rails/activestorage"; | ||
| ActiveStorage.start(); | ||
|
|
There was a problem hiding this comment.
@jmilljr24 i think the rest of this PR is ok to merge without much fanfare, except for this. not sure if this is needed at all since removing it from the old asset pipeline configs under app/assets?
There was a problem hiding this comment.
Yes we need to import this somewhere. I didn't realize it wasn't in here.
|
@jmilljr24 jk there's one more item -- i broke the register, de-register again. there's 1 failing test about it. |
|
@maebeale I recall @johnpaulashenfelter did some work to precompile some css assets early on in this is project? I don't know if any of that is still helpful or just a temp thing. |
c55d6aa to
495d3c7
Compare
|
@jmilljr24 yeah, we did that bc we had old bootstrap and other css the site still needed to function. so he bundled what we had so we could have manifests while also starting to delete old directories. since moving to tailwind and vite, we don't have need for any of these assets anymore. |
What is the goal of this PR and why is this important?
data: { confirm: "" }mgs todata: { turbo_method: :delete, turbo_confirm: "" }How did you approach the change?
Anything else to add?