Skip to content

Remove unused assets from project#869

Open
maebeale wants to merge 3 commits intomainfrom
remove-old-assets
Open

Remove unused assets from project#869
maebeale wants to merge 3 commits intomainfrom
remove-old-assets

Conversation

@maebeale
Copy link
Collaborator

@maebeale maebeale commented Feb 8, 2026

What is the goal of this PR and why is this important?

  • Remove unused asset files incl:
    • fonts
    • images
    • css
    • js
  • Removal of ujs made me have to switch all our data: { confirm: "" } mgs to data: { turbo_method: :delete, turbo_confirm: "" }

How did you approach the change?

Anything else to add?

import "@rails/activestorage"
import * as ActiveStorage from "@rails/activestorage";
ActiveStorage.start();

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmilljr24 i think the rest of this PR is ok to merge without much fanfare, except for this. not sure if this is needed at all since removing it from the old asset pipeline configs under app/assets?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we need to import this somewhere. I didn't realize it wasn't in here.

@maebeale
Copy link
Collaborator Author

maebeale commented Feb 8, 2026

@jmilljr24 jk there's one more item -- i broke the register, de-register again. there's 1 failing test about it.

@jmilljr24
Copy link
Collaborator

@maebeale I recall @johnpaulashenfelter did some work to precompile some css assets early on in this is project? I don't know if any of that is still helpful or just a temp thing.

@maebeale
Copy link
Collaborator Author

maebeale commented Feb 9, 2026

@jmilljr24 yeah, we did that bc we had old bootstrap and other css the site still needed to function. so he bundled what we had so we could have manifests while also starting to delete old directories. since moving to tailwind and vite, we don't have need for any of these assets anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove old assets from the repo

2 participants