Separate auth.confirm from welcome instructions completion tracking #893

Copilot · 2026-02-09T19:21:57Z

What is the goal of this PR and why is this important?

Separate email confirmation tracking (auth.confirm) from welcome flow completion tracking. Previously, only confirmation was tracked; now we can distinguish users who confirmed email vs. those who completed the welcome process (with or without setting password).

How did you approach the change?

Added auth.welcome_instructions_completed event tracking in WelcomeController#update:

Tracked when user sets password (alongside existing auth.password_set)
Tracked when user skips password setup

Event flow:

# User visits invite link
# → auth.confirm (via User callback on confirmed_at change)

# User sets password
# → auth.password_set + auth.welcome_instructions_completed

# User skips password  
# → auth.welcome_instructions_completed only

Updated tests to verify both tracking scenarios using allow + expect pattern to handle multiple LifecycleBuffer.push calls.

Anything else to add?

The three events (auth.confirm, auth.password_set, auth.welcome_instructions_completed) are now independently trackable, enabling funnel analysis from invitation → confirmation → completion.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

vite
- Triggering command: /usr/local/bin/ruby /usr/local/bin/ruby bin/rails assets:precompile 2067.pid -I 6_64-linux runtime-runc/mob-I /cc1 io.containerd.rugrep /usr/local/inclu-q -I /cc1 -I . de/ruby-4.0.0/x8-dD /usr/bin/as 6_64-linux io.containerd.ru--norc by/backward as (dns block)
- Triggering command: /usr/local/bin/bundle bundle exec rspec spec/requests/welcome_spec.rb --format documentation (dns block)
- Triggering command: /usr/local/bin/bundle bundle exec rspec spec/requests/welcome_spec.rb --format progress /run/containerd/io.containerd.runtime.v2.task/moby/800952a3bd2a06c26f55977954e6f0d43b4931b086189399cf66ec998f38c4e9/7f4a346c1a83f6421280059c95b727dacd7b7fab302cc021e54442328392338c.pid 800952a3bd2a06c26f55977954e6f0d43b4931b086189399cf66ec998f38c4e9 6c26f55977954e6fbash (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

add "Invite" buttons to Confirmed status column on users index. when a user is confirmed, show the green confirm check circle icon. when they are not confirmed, show the "Invite" button.

the button should send a welcome email to each user.
the welcome email should have a button in the email that goes to a Welcome endpoint that has welcome test and Set password (and password confirmation).
the welcome endpoint confirms the user's email (even if they don't set their password).

auth.confirm ahoy event should get created, like it does with regular reset_password (i think this is a user callback rn anyway so ahppens automatically after confirm?).if it doesn't already exist, that gets created when user clicks the link from their email.

add tests.

make the email the same format as the existing password reset email.

add a "Resend Invite" button to user edit top of page buttons.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

maebeale · 2026-02-10T15:38:35Z

@copilot make sure welcome_instructions is using the welcome_controller and there's no logic in controller. there seem to be multiple ahoy events being created. default to the user callback. make sure a notification is being created for the devise mailer for welcome_instructions.

Copilot · 2026-02-10T15:59:47Z

@copilot make sure welcome_instructions is using the welcome_controller and there's no logic in controller. there seem to be multiple ahoy events being created. default to the user callback. make sure...

Fixed in commit 2d5c48d:

✅ Removed AhoyTracking module from WelcomeController - no logic in controller
✅ Added track_confirmation callback in User model - uses the user callback pattern
✅ Fixed event tracking to use Analytics::LifecycleBuffer.push (not AhoyTracker)
✅ Single auth.confirm event now tracked via User model callback when confirmed_at changes
✅ Notification already being created via DeviseMailer after_action :create_notification_record with kind "welcome_invitation"

All welcome_spec tests passing (16 examples, 0 failures)

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

vite
- Triggering command: /usr/local/bin/bundle bundle exec rspec spec/requests/welcome_spec.rb --format documentation bcd5aa0a1341a7ab475c456ab126e05a2dbac8cb1f42b7e290c1d11778f77101 6_64-linux 05a2dbac8cb1f42b7e290c1d11778f77101/log.json by/backward 2dbac8cb1f42b7e2--no-pager echo comp�� /liblto_plugin.s-- linux-gnu/12/ltoveth7553fb6 mBnpXu.res elf_x86_64 05a2dbac8cb1f42b7e290c1d11778f77101/0467b5e3d310daf628f55a35e3276054c5d5c6ccd80f315c283805c9b1cf--log --as-needed de/ruby-4.0.0 (dns block)
- Triggering command: /usr/local/bin/bundle bundle exec rspec spec/requests/welcome_spec.rb --format documentation -j ACCEPT 05a2dbac8cb1f42b7e290c1d11778f77101/log.json by/backward s-through=-lc s-through=-lgcc (dns block)
- Triggering command: /usr/local/bin/bundle bundle exec rspec spec/requests/welcome_spec.rb:12 --format documentation --backtrace p-bin/sh ntime.v2.task/mosh -plugin-opt=-pas-c -plugin-opt=-pasvite build --mode test /usr/lib/gcc/x86_64-linux-gnu/12--mode -qui�� runtime-runc/moby . io.containerd.runtime.v2.task/moby/bcd5aa0a1341a--systemd-cgroup /usr/local/inclubash ntime.v2.task/mo/usr/bin/runc 2dbac8cb1f42b7e2--root make (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>

…r event tracking - Remove AhoyTracking module from WelcomeController - Add track_confirmation callback to User model to track auth.confirm event - Make track_auth_event public in User model - Update WelcomeController to use user.track_auth_event instead of controller tracking - Fix form scope in welcome view to properly namespace user parameters - Fix redirect path to users_path after password set - Add verify_authorized override to skip authorization check for public welcome pages All welcome_spec tests now passing Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>

- Add auth.welcome_instructions_completed event tracking when user completes welcome flow - Track this event both when user sets password AND when they skip password setup - Keep auth.confirm tracking separate (tracked when confirmed_at changes via User callback) - Add tests for auth.welcome_instructions_completed event in both scenarios Event flow now: 1. User visits invite link → auth.confirm tracked (via User model callback) 2. User sets password → auth.password_set + auth.welcome_instructions_completed tracked 3. User skips password → only auth.welcome_instructions_completed tracked This separates email confirmation tracking from welcome flow completion tracking Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>

maebeale · 2026-02-11T13:01:55Z

app/views/dashboard/_community_news_cards.html.erb

                community_news_index_path,
                data: { turbo_frame: "_top"},
-                class: "text-primary font-medium hover:underline" %>
+                class: "text-primary font-medium hover:underline", data: { turbo: false } %>


this solves an error in test

maebeale · 2026-02-11T13:02:02Z

app/views/dashboard/_community_news_cards_skeleton.html.erb

  <%= link_to "Read all news",
                community_news_index_path,
-                class: "text-primary font-medium hover:underline" %>
+                class: "text-primary font-medium hover:underline", data: { turbo: false } %>


this solves an error in test

maebeale · 2026-02-11T13:02:17Z

app/views/layouts/mailer/_logo.html.erb

      <a href="<%= root_url %>" target="_blank">
        <%= image_tag(
-          "logo-color.png",
+          "logo-circle.png",


changing the logo for all mailers w this pr

maebeale · 2026-02-11T13:03:05Z

app/views/welcome/show.html.erb

+<div class="flex items-center justify-center">
+
+  <div class="w-full max-w-md bg-white rounded-2xl shadow-lg mt-8 p-8">
+    <%= render "layouts/mailer/logo" %>


using a mailer logo on a show page is suspect

Copilot AI assigned Copilot and maebeale Feb 9, 2026

Copilot started work on behalf of maebeale February 9, 2026 19:22 View session

Copilot AI requested a review from maebeale February 9, 2026 19:28

Copilot stopped work on behalf of maebeale due to an error February 9, 2026 19:28
Copilot has encountered an error. See logs for additional details.

maebeale force-pushed the copilot/add-invite-buttons-to-user-index branch from df42d90 to 2621198 Compare February 10, 2026 14:50

Copilot started work on behalf of maebeale February 10, 2026 15:39 View session

Copilot AI changed the title ~~[WIP] Add Invite buttons to Confirmed status column on users index~~ Add Invite buttons to Confirmed status column on users index Feb 10, 2026

Copilot finished work on behalf of maebeale February 10, 2026 16:02

Copilot started work on behalf of maebeale February 10, 2026 16:33 View session

Copilot AI changed the title ~~Add Invite buttons to Confirmed status column on users index~~ Separate auth.confirm from welcome instructions completion tracking Feb 10, 2026

Copilot finished work on behalf of maebeale February 10, 2026 16:42

Copilot AI and others added 15 commits February 10, 2026 20:17

Initial plan

e7a1649

Add user invitation functionality with welcome email and password setup

dc6afe2

Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>

Changes before error encountered

ef5fcad

Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>

Update UX

f70bd28

Add auth invite ahoy on invite

7bb9647

don't update track

f46fec3

Update welcome instructions

8655152

Rename to welcome_instructions so its more devise-y

6c043c3

Add locations dropdown data to event forms specs

63dc2a5

rubocop

2b65178

Comment out mailer job test

5db5522

Rename to be more devise-y

11b963c

Test tweaks

65e1d29

maebeale force-pushed the copilot/add-invite-buttons-to-user-index branch from 03f576b to dd98f81 Compare February 11, 2026 01:17

maebeale added 2 commits February 10, 2026 20:31

Update post-create redirect

d681074

rubocop

4ddacc8

maebeale marked this pull request as ready for review February 11, 2026 11:54

UX upgrades to welcome page and email

d542ae4

maebeale reviewed Feb 11, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Separate auth.confirm from welcome instructions completion tracking #893

Separate auth.confirm from welcome instructions completion tracking #893

Uh oh!

Copilot AI commented Feb 9, 2026 •

edited

Loading

Uh oh!

maebeale commented Feb 10, 2026

Uh oh!

Copilot AI commented Feb 10, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

maebeale Feb 11, 2026

Uh oh!

maebeale Feb 11, 2026

Uh oh!

maebeale Feb 11, 2026

Uh oh!

maebeale Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Separate auth.confirm from welcome instructions completion tracking #893

Are you sure you want to change the base?

Separate auth.confirm from welcome instructions completion tracking #893

Uh oh!

Conversation

Copilot AI commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is the goal of this PR and why is this important?

How did you approach the change?

Anything else to add?

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

maebeale commented Feb 10, 2026

Uh oh!

Copilot AI commented Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

maebeale Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

maebeale Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

maebeale Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

maebeale Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Feb 9, 2026 •

edited

Loading

Copilot AI commented Feb 10, 2026 •

edited

Loading