Extract story share functionality into dedicated StoryShareController #916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial plan * Redesign share_portal page with Tailwind CSS to match design Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Add full-width layout support for share_portal page Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Address code review feedback: add accessibility labels and use dynamic story links Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Create separate layout for story share portal with purple navigation Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Address code review feedback: remove redundant nav wrapper and duplicate link Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>
* Initial plan * Add Telefon font, redesign navbar with 3 rows, update sector styling and overlays Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Refine font declarations and remove unused CSS variables Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Fix Tailwind class interpolation and improve scroll performance Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> * Use actual story sectors for category badges in What Others Are Reading Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>
* Initial plan * Update story share portal navigation and layout to match design Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>
* Initial plan * Update Story Share Portal layout per feedback Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>
Merged
…Controller Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>
Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update story share portal implementation
Extract story share functionality into dedicated StoryShareController
Feb 10, 2026
maebeale
force-pushed
the
story-share-portal
branch
3 times, most recently
from
9bc3fe9 to
6e5832b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
The main application is called "the Portal." Having story share functionality under
share_portalcreates naming confusion. This extracts story share into its own controller with clearer semantics.How did you approach the change?
Controller separation:
StoryShareControllerwith read-onlyindexandshowactionsshare_portalandshow_share_portalfromStoriesControllerGET /stories/share_portal→GET /stories/shareView structure:
stories/share_portal.html.erb→story_share/index.html.erblayouts/share_portal.html.erb→layouts/story_share.html.erb_share_portal_navbar.html.erb→_story_share_navbar.html.erbshare_portal_stories_path→story_share_index_pathPreserved:
Anything else to add?
The old
share_portalfiles are intentionally retained to prevent breaking bookmarked URLs during transition.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.