Workshop and resource mentions #925
Merged
+402
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmilljr24
commented
Feb 11, 2026
| <hr class="border-gray-300 mb-2"> | ||
|
|
||
| <div class="flex flex-wrap gap-4"> | ||
| <div class="assets"> |
Collaborator
Author
There was a problem hiding this comment.
This was breaking the flex of the gallery. I don't think this is used for any css.
jmilljr24
commented
Feb 11, 2026
| @@ -1,6 +1,7 @@ | |||
| class ResourceMentionsController < ApplicationController | |||
| skip_verify_authorized | |||
Collaborator
Author
There was a problem hiding this comment.
I'm going to have to dive into action policy a bit more for these. The controller is being hit from the js on the fly so I don't know what context the controller has access to.
This is relatively minor to disable the policy check right now for this because the editor route is already checked via the policy. I can adjust it later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
Consolidate all workshop and resource mentions with rich_text to a card on the show page. I could use a better title for the card!
How did you approach the change?
Check all rich_text fields for mention embeds.
Anything else to add?
screenrecording-2026-02-11_07-37-42.mp4