This repository was archived by the owner on Dec 4, 2023. It is now read-only.
ensure idenity map entries are cleaned up:#384
Open
cowboyd wants to merge 1 commit intoupgrade-to-v8-4.5from
Open
ensure idenity map entries are cleaned up:#384cowboyd wants to merge 1 commit intoupgrade-to-v8-4.5from
cowboyd wants to merge 1 commit intoupgrade-to-v8-4.5from
Conversation
This adds a regression for: #336
Collaborator
There was a problem hiding this comment.
Hmmm... Wouldn't it be nicer if we just put the example in a pending state with a message that it should only be run only newer versions of ruby?
Collaborator
Author
There was a problem hiding this comment.
Yeah, probably so. I'll fix that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a regression for:
#336
In order to test this, it also needed the ability to null out an object within a context, so a conversion for
nilwas included.