This repository was archived by the owner on Dec 4, 2023. It is now read-only.
README.md: Syntax highlighting everywhere#435
Open
msabramo wants to merge 1 commit intorubyjs:masterfrom
Open
Conversation
Syntax highlighting was being used in many places already. Extended it to more places.
Collaborator
|
oops, I did the same #450 @ignisf To answer your question, Fenced code blocks with an info string are part of CommonMark specs not only GFM (see https://spec.commonmark.org/0.28/#example-111). |
olleolleolle
approved these changes
May 11, 2020
olleolleolle
left a comment
There was a problem hiding this comment.
From a random passer-by: This looks good to merge. Makes the README easier to scan.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syntax highlighting was being used in many places already.
Extended it to more places.
See https://github.com/msabramo/therubyracer/blob/patch-1/README.md