Remove win32console requirement in ruby 2.0.0 and higher#35
Open
Darunada wants to merge 1 commit intorubyworks:masterfrom
Darunada:remove-win32console-in-ruby-2
Open
Remove win32console requirement in ruby 2.0.0 and higher#35Darunada wants to merge 1 commit intorubyworks:masterfrom Darunada:remove-win32console-in-ruby-2
Darunada wants to merge 1 commit intorubyworks:masterfrom
Darunada:remove-win32console-in-ruby-2
Conversation
Author
|
The CI check seems to fail because it's using an outdated version of bundler. |
|
Would it be possible to get this PR merged? A few gems depend on this |
|
For anyone else (or myself in the future) that might be looking for ways to address the issue of # test_helper.rb
# Kludge: minitest-reporter depend on the `ansi` gem which hasn't been updated
# for a very long time. It's expecting to use another `win32console` gem in
# order to provide colorized output on Windows even though that is not longer
# needed. This works around that by fooling Ruby to think it has been loaded.
#
# https://github.com/rubyworks/ansi/issues/36
# https://github.com/rubyworks/ansi/pull/35
$LOADED_FEATURES << 'Win32/Console/ANSI'
Minitest::Reporters.use! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows ansi to color output in windows with ruby 2+ without attempting to load win32console
The win32console gem is no longer required for ruby 2 or higher in Windows.
See: luislavena/win32console#17 (comment)