feat(Resolve-ProjectParameters): Remove sticky project environment setting

Test/private/MockCall_Project700.ps1

@@ -170,7 +170,7 @@ function Get-Mock_Project_700 {
     $project.searchInTitle = @{}
     $project.searchInTitle.titleFilter = "development"
     $project.searchInTitle.Titles = $pActual.items.nodes.content.title | Where-Object { $_ -like "*development*" }
-    $project.searchInTitle.attributesDefault = @("Title", "id")
+    $project.searchInTitle.attributesDefault = @("Title", "id" , "RepositoryName")
     $project.searchInTitle.attributes = @("Title", "id", "url", "Status", "field-text")
 
     # SearchIn FieldName

Test/public/integrations/sync-ProjectItemsBetweenProjects.test.ps1

@@ -22,7 +22,7 @@ function Test_UpdateProjectItemsBetweenProjects{
 
     Assert-IsNull -Object $result
 
-    $staged = Get-ProjectItemStaged -Owner $owner -ProjectNumber $destinationProjectNumber
+    $staged = Get-ProjectItemStaged -Owner $destinationOwner -ProjectNumber $destinationProjectNumber
 
     $p = $p626.syncBtwPrj_625
 

Test/public/interactive_test/getproject.test.ps1

@@ -9,8 +9,10 @@ function Test_Get_Project_ItemId_Equal_Case_Sensitive {
     $item1 = "PVTI_lADOAlIw4c4BCe3Vzgec8pU"
     $item2 = "PVTI_lADOAlIw4c4BCe3Vzgec8pu"
 
+    Set-ProjectHelperEnvironment -Owner $owner -ProjectNumber $projectNumber
+
     # Act
-    $result = Get-Project -owner $owner -ProjectNumber $ProjectNumber
+    $result = Get-Project
     Assert-Count -Expected $p.items.totalCount -Presented $result.items.keys
 
     $result1 = Get-ProjectItem -ItemId $item1

Test/public/issues/Add-IssuePullRequestComment.test.ps1

@@ -22,7 +22,7 @@
 
 function Test_AddComment_SUCCESS_Using_Direct{
 
-    $p = Get-Mock_Project_700
+    $p = Get-Mock_Project_700 
     $i = $p.Issue
     $id = $i.id
     $contentId = $i.contentId

Test/public/issues/Get-ProjectIssue.test.ps1

@@ -1,12 +1,12 @@
 function Test_GetProjectIssue{
 
-    $p = Get-Mock_Project_700 ; $Owner = $p.owner ; $projectNumber = $p.number
+    $p = Get-Mock_Project_700
     $i = $p.issue
 
     MockCallJson -Command "Invoke-GetIssueOrPullRequest -Url $($i.url)" -FileName "invoke-GetIssueOrPullRequest-26.json"
 
     # Act
-    $result = Get-ProjectIssue -Url $i.url
+    $result = Get-ProjectIssue -Url $i.url 
 
     Assert-AreEqual -Expected $i.contentId -Presented $result.id
     Assert-AreEqual -Expected $i.title -Presented $result.title

Test/public/issues/Remove-ProjectIssue.test.ps1

@@ -9,7 +9,7 @@ function Test_RemoveProjectIssue_SUCCESS {
     MockCallJson -Command "Invoke-GetIssueOrPullRequest -Url $($i.url)" -fileName $i.getIssueOrPullRequestMockFile
     MockCallJson -Command "Invoke-AddItemToProject -ProjectId $($p.id) -ContentId $($i.id)" -fileName $i.addIssueToOProjectMockFile
     $itemId = Add-ProjectItem -owner $owner -projectNumber $projectNumber -Url $i.url
-    $item = Get-ProjectItem -Id $itemId
+    $item = Get-ProjectItem -Id $itemId -owner $owner -projectNumber $projectNumber
     Assert-AreEqual -expected $i.id -Presented $item.contentId
 
     MockCallJson -Command "Invoke-RemoveItemFromProject -ProjectId $($p.id) -ItemId $($i.itemId)" -fileName $i.removeIssueFromProjectMockFile
@@ -19,11 +19,11 @@ function Test_RemoveProjectIssue_SUCCESS {
 
     # Assert
     Assert-AreEqual -Expected $i.url -Presented $result
-    Assert-IsFalse -Condition $(Test-ProjectItem -Url $i.url)
+    Assert-IsFalse -Condition $(Test-ProjectItem -Url $i.url -Owner $owner -ProjectNumber $projectNumber)
 
-    # Remove issue assocaited
+    # Remove issue associated
     $itemId = Add-ProjectItem -owner $owner -projectNumber $projectNumber -Url $i.url
-    Assert-IsTrue -Condition $(Test-ProjectItem -Url $i.url)
+    Assert-IsTrue -Condition $(Test-ProjectItem -Url $i.url -Owner $owner -ProjectNumber $projectNumber)
     MockCallJson -Command "Invoke-RemoveIssue -IssueId $($i.id)" -FileName "invoke-removeissue-any.json"
 
     # Act

Test/public/items/project_item_draftissue.test.ps1

@@ -11,10 +11,8 @@ function Test_NewProjectDraftIssue {
     # Act
     $draftIssueId = New-ProjectDraftIssueDirect -Owner $owner -ProjectNumber $projectNumber -Title $title -Body $body
 
-
-    $item = Get-ProjectItem -ItemId $draftIssueId
-
     # Assert
+    $item = Get-ProjectItem -ItemId $draftIssueId -Owner $owner -ProjectNumber $projectNumber
     Assert-AreEqual -Expected $draftIssueId -Presented $item.id
     Assert-AreEqual -Expected $title -Presented $item.Title
     Assert-AreEqual -Expected $body -Presented $item.Body

Test/public/items/use_order.test.ps1

@@ -12,13 +12,34 @@ function Test_UserOrder_Success{
 
 }
 
-function Test_UserOrder_Success_GetItem{
+function Test_UserOrder_Success_GetItem_FAIL_NO_ENVIRONMENT{
     MockCall_GetProject_700
 
     $p = Get-Mock_Project_700 ; $owner = $p.owner ; $projectNumber = $p.number
 
+    # We need to have the environment set to get item details in PassThru
     $list = Search-ProjectItem -Owner $owner -ProjectNumber $projectNumber -IncludeDone
 
+    # Act
+    $hasthorwn = $false
+    try {
+        $list | Use-Order 1
+    } catch {
+        $hasthorwn = $true
+        Assert-IsTrue -Condition $_.Exception.Message.StartsWith("ProjectEnvironment is required.")
+    }
+    Assert-IsTrue -Condition $hasthorwn
+}
+
+function Test_UserOrder_Success_GetItem{
+    MockCall_GetProject_700
+
+    $p = Get-Mock_Project_700 ; $owner = $p.owner ; $projectNumber = $p.number
+
+    # We need to have the environment set to get item details in PassThru
+    Set-ProjectHelperEnvironment -Owner $owner -ProjectNumber $projectNumber
+    $list = Search-ProjectItem -IncludeDone
+
     # Act
     $result = $list | Use-Order 1 -PassThru
 
@@ -33,7 +54,9 @@ function Test_UserOrder_Success_OpenBrowser{
 
     MockCallToNull -command "Invoke-ProjectHelperOpenUrl -Url $url"
 
-    $list = Search-ProjectItem -Owner $owner -ProjectNumber $projectNumber -IncludeDone
+    # We need to have the environment set to get item details in PassThru
+    Set-ProjectHelperEnvironment -Owner $owner -ProjectNumber $projectNumber
+    $list = Search-ProjectItem -IncludeDone
 
     # Act
     $result = $list | Use-Order $order -OpenInBrowser
@@ -48,7 +71,9 @@ function Test_UserOrder_Success_Passthru{
     $p = Get-Mock_Project_700 ; $owner = $p.owner ; $projectNumber = $p.number
     $order = $p.issue.order ; $id = $p.issue.id
 
-    $list = Search-ProjectItem -Owner $owner -ProjectNumber $projectNumber -IncludeDone
+    # We need to have the environment set to get item details in PassThru
+    Set-ProjectHelperEnvironment -Owner $owner -ProjectNumber $projectNumber
+    $list = Search-ProjectItem -IncludeDone
 
     # Act
     $result = $list | Use-Order $order -PassThru

Test/public/project_item.searchprojectitem.test.ps1

@@ -7,18 +7,22 @@ function Test_SearchProjectItem_Basic_SUCCESS {
     $p = Get-Mock_Project_700
     $Owner = $p.owner
     $ProjectNumber = $p.number
-    $filter = $p.searchInTitle.titleFilter
-    $expected = $p.searchInTitle.Titles.Count
+    $s = $p.searchInTitle
+    $filter = $s.titleFilter
+    $expected = $s.Titles.Count
+    $defautlAttrs = $s.attributesDefault
 
     $result = Search-ProjectItem -Owner $Owner -ProjectNumber $ProjectNumber -Filter $filter
     Assert-Count -Expected $expected -Presented $result
 
-    # Default attributes should be id + Title
+    # Default attributes should be id + Title + RepositoryName
     foreach($r in $result){
         $props = $r.PSObject.Properties.Name
-        Assert-Count -Expected 2 -Presented $props
-        Assert-Contains -Expected "id" -Presented $props
-        Assert-Contains -Expected "Title" -Presented $props
+
+        Assert-Count -Expected $defautlAttrs.Count -Presented $props
+        $defautlAttrs | ForEach-Object -Process {
+            Assert-Contains -Expected $_ -Presented $props
+        }
     }
 }
 

Test/public/project_item.test.ps1

@@ -192,7 +192,7 @@ function Test_TestProjectItem_Success{
 
     # Not found
 
-    $result = Test-ProjectItem -Url "https://github.com/octodemo/Project-700/issues/999"
+    $result = Test-ProjectItem -Url "https://github.com/octodemo/Project-700/issues/999" -Owner $owner -ProjectNumber $projectNumber
     Assert-IsFalse -Condition $result
 
 }

Test/public/project_items_staged.test.ps1

@@ -15,7 +15,7 @@ function Test_SyncProjectItemsStaged_NoStaged {
 
 function Test_SyncProjectItemsStaged_SUCCESS_Number{
 
-    $Owner = "octodemo" ; $ProjectNumber = 700
+    $p = Get-Mock_Project_700 ; $owner = $p.owner ; $projectNumber = $p.number
     $projectId = "PVT_kwDOAlIw4c4BCe3V"
 
     # project item issue
@@ -52,8 +52,7 @@ function Test_SyncProjectItemsStaged_SUCCESS_Number{
 
     # Mock get-project
     # MockCall_GetProject_700 -skipItems
-    MockCall_GetProject_700
-    $null = Get-Project -Owner $Owner -ProjectNumber $ProjectNumber -Force
+    MockCall_GetProject -MockProject $p -Cache
 
     Edit-ProjectItem -Owner $owner -ProjectNumber $projectNumber $itemId1 $fieldName $fieldValue
 
@@ -62,7 +61,7 @@ function Test_SyncProjectItemsStaged_SUCCESS_Number{
     $staged = Get-ProjectItemStaged -Owner $Owner -ProjectNumber $ProjectNumber
     Assert-AreEqual -Expected $fieldValue -Presented $staged.$itemId1.$fieldId.Value
 
-    $showStaged = Show-ProjectItemStaged -Owner $Owner -ProjectNumber $ProjectNumber | Show-ProjectItemStaged
+    $showStaged = Show-ProjectItemStaged -Owner $Owner -ProjectNumber $ProjectNumber | Show-ProjectItemStaged -Owner $Owner -ProjectNumber $ProjectNumber
     Assert-AreEqual -Expected $fieldValue -Presented $showStaged.$fieldName.Value
     Assert-AreEqual -Expected $fieldBeforeValueNumber -Presented $showStaged.$fieldName.Before
 
@@ -81,7 +80,6 @@ function Test_SyncProjectItemsStaged_SUCCESS_Number{
 
 function Test_SyncProjectItemsStaged_SUCCESS_Date{
 
-    $Owner = "octodemo" ; $ProjectNumber = 700
     $projectId = "PVT_kwDOAlIw4c4BCe3V"
 
     # project item issue
@@ -117,8 +115,8 @@ function Test_SyncProjectItemsStaged_SUCCESS_Date{
     }
 
     # Mock get-project
-    MockCall_GetProject_700
-    $null = Get-Project -Owner $Owner -ProjectNumber $ProjectNumber
+    $p = Get-Mock_Project_700 ; $owner = $p.owner ; $projectNumber = $p.number
+    MockCall_GetProject -MockProject $p -Cache
 
     Edit-ProjectItem -Owner $owner -ProjectNumber $projectNumber $itemId1 $fieldName $fieldValue
 
@@ -127,7 +125,8 @@ function Test_SyncProjectItemsStaged_SUCCESS_Date{
     $staged = Get-ProjectItemStaged -Owner $Owner -ProjectNumber $ProjectNumber
     Assert-AreEqual -Expected $fieldValue -Presented $staged.$itemId1.$fieldId.Value
 
-    $showStaged = Show-ProjectItemStaged -Owner $Owner -ProjectNumber $ProjectNumber | Show-ProjectItemStaged
+    # During interactive use we will set project environment avoiding to use the owner an PN parameters
+    $showStaged = Show-ProjectItemStaged -Owner $Owner -ProjectNumber $ProjectNumber | Show-ProjectItemStaged -Owner $Owner -ProjectNumber $ProjectNumber
     Assert-AreEqual -Expected $fieldValue -Presented $showStaged.$fieldName.Value
     Assert-AreEqual -Expected $fieldBeforeValueDate -Presented $showStaged.$fieldName.Before
 
@@ -205,7 +204,7 @@ function Test_SyncProjectItemsStaged_SUCCESS_SingleSelect{
         }
     }
 
-    $showStaged = Show-ProjectItemStaged -Owner $Owner -ProjectNumber $ProjectNumber | Show-ProjectItemStaged
+    $showStaged = Show-ProjectItemStaged -Owner $Owner -ProjectNumber $ProjectNumber | Show-ProjectItemStaged -Owner $Owner -ProjectNumber $ProjectNumber
     Assert-AreEqual -Expected $fieldNewValue -Presented $showStaged.$fieldName.Value
     Assert-AreEqual -Expected $fieldBeforeValueSingleSelect -Presented $showStaged.$fieldName.Before
 

private/projectDatabase/project_database_Async.ps1

@@ -7,8 +7,7 @@ function Sync-ProjectDatabaseAsync {
         [Parameter()][int]$SyncBatchSize = 30
     )
 
-    ($Owner, $ProjectNumber) = Get-OwnerAndProjectNumber -Owner $Owner -ProjectNumber $ProjectNumber
-    if ([string]::IsNullOrWhiteSpace($owner) -or [string]::IsNullOrWhiteSpace($ProjectNumber)) { "Owner and ProjectNumber are required" | Write-MyError; return $null }
+($owner,$ProjectNumber) = Resolve-ProjectParameters -Owner $Owner -ProjectNumber $ProjectNumber
 
     if (! $(Test-ProjectDatabaseStaged -Owner $Owner -ProjectNumber $ProjectNumber)) {
         "Nothing to commit" | Write-MyHost

private/projectDatabase/project_database_Sync.ps1

@@ -7,8 +7,7 @@ function Sync-ProjectDatabase{
         [Parameter()][int]$ProjectNumber
     )
 
-    ($Owner,$ProjectNumber) = Get-OwnerAndProjectNumber -Owner $Owner -ProjectNumber $ProjectNumber
-    if([string]::IsNullOrWhiteSpace($owner) -or [string]::IsNullOrWhiteSpace($ProjectNumber)){ "Owner and ProjectNumber are required" | Write-MyError; return $null}
+    ($Owner,$ProjectNumber) = Resolve-ProjectParameters -Owner $Owner -ProjectNumber $ProjectNumber
 
     if(! $(Test-ProjectDatabaseStaged -Owner $Owner -ProjectNumber $ProjectNumber)){
         "Nothing to commit" | Write-MyHost

public/environment/environmentCache.ps1

@@ -1,5 +1,5 @@
 
-$DEFAULT_DISPLAY_FIELDS = @("id","title")
+$DEFAULT_DISPLAY_FIELDS = @("id","Title")
 
 function Get-ProjectHelperEnvironment{
     [CmdletBinding()]
@@ -51,38 +51,6 @@ function Set-ProjectHelperEnvironment{
 
 } Export-ModuleMember -Function Set-ProjectHelperEnvironment
 
-function Get-OwnerAndProjectNumber{
-    [CmdletBinding()]
-    param(
-        [Parameter()][string]$Owner,
-        [Parameter()][string]$ProjectNumber
-    )
-
-    if($ProjectNumber -eq "0"){
-        $ProjectNumber = [string]::Empty
-    }
-
-    $ownerCache = Get-EnvItem -Name "EnvironmentCache_Owner"
-    if([string]::IsNullOrWhiteSpace($Owner)){
-        $owner = $ownerCache
-    } else {
-        if($owner -ne $ownerCache){
-            Set-EnvItem -Name "EnvironmentCache_Owner" -Value $Owner
-        }
-    }
-
-    $projectNumberCache = Get-EnvItem -Name "EnvironmentCache_ProjectNumber"
-    if([string]::IsNullOrWhiteSpace($ProjectNumber)){
-        $ProjectNumber = $projectNumberCache
-    } else {
-        if($ProjectNumber -ne $projectNumberCache){
-            Set-EnvItem -Name "EnvironmentCache_ProjectNumber" -Value $ProjectNumber
-        }
-    }
-
-    return ($owner, $ProjectNumber)
-}
-
 function Get-EnvironmentDisplayFields{
     [CmdletBinding()]
     param(

public/environment/resolveProjectParameters.ps1

@@ -0,0 +1,59 @@
+function Resolve-ProjectParameters {
+    [CmdletBinding()]
+    param(
+            [Parameter(Position = 0)][string]$ProjectNumber,
+            [Parameter(Position = 1)][string]$Owner,
+            [Parameter()][switch]$DoNotThrow
+
+        )
+
+        if($ProjectNumber -eq 0){
+            $ProjectNumber = ""
+        }
+
+        if([string]::IsNullOrWhiteSpace($Owner)){
+            $Owner = Get-EnvItem -Name "EnvironmentCache_Owner"
+        }
+
+        if([string]::IsNullOrWhiteSpace($ProjectNumber)){
+            $ProjectNumber = Get-EnvItem -Name "EnvironmentCache_ProjectNumber"
+        }
+
+        if([string]::IsNullOrWhiteSpace($ProjectNumber) -or [string]::IsNullOrWhiteSpace($Owner)){
+            if(-Not $DoNotThrow){
+                throw "Owner and ProjectNumber parameters are required. Please provide them as parameters or set them in the environment cache."
+            } else {
+                Write-MyDebug "Owner or ProjectNumber is missing. Returning null values." -Section "Resolve-ProjectParameters"
+                return ($null, $null)
+            }
+        }
+
+        return ($Owner, $ProjectNumber)
+}
+
+function Test-ProjectParameters {
+    [CmdletBinding()]
+    param(
+        [Parameter(Position = 0)][string]$ProjectNumber,
+        [Parameter(Position = 1)][string]$Owner
+    )
+
+    ($Owner, $ProjectNumber) = Resolve-ProjectParameters -Owner $Owner -ProjectNumber $ProjectNumber -DoNotThrow
+
+    return -not ([string]::IsNullOrWhiteSpace($Owner) -or [string]::IsNullOrWhiteSpace($ProjectNumber))
+}
+
+function Set-ProjectParameters {
+    [CmdletBinding()]
+    [Alias("Set-Project")]
+    param(
+        [Parameter(Mandatory,ValueFromPipelineByPropertyName, Position = 0)][string]$Owner,
+        [Parameter(Mandatory,ValueFromPipelineByPropertyName, Position = 1)][string]$ProjectNumber
+    )
+
+    process {
+
+        Set-ProjectHelperEnvironment -Owner $Owner -ProjectNumber $ProjectNumber
+    }
+
+} Export-ModuleMember -Function Set-ProjectParameters -Alias "Set-Project"

public/fields/project_fields_list.ps1

@@ -40,8 +40,7 @@ function Get-ProjectFields{
         [Parameter()][switch]$Force
     )
 
-    ($Owner,$ProjectNumber) = Get-OwnerAndProjectNumber -Owner $Owner -ProjectNumber $ProjectNumber
-    if([string]::IsNullOrWhiteSpace($owner) -or [string]::IsNullOrWhiteSpace($ProjectNumber)){ "Owner and ProjectNumber are required" | Write-MyError; return $null}
+    ($Owner,$ProjectNumber) = Resolve-ProjectParameters -Owner $Owner -ProjectNumber $ProjectNumber
 
     $db = Get-Project -Owner $Owner -ProjectNumber $ProjectNumber -Force:$Force -SkipItems