Open
Conversation
Author
|
I had to backport this to an older version of Ruma so I can't test it. But so far I have not managed to figure out how to get this request to implement EDIT: ah, the |
jplatte
approved these changes
Jan 26, 2024
Member
jplatte
left a comment
jplatte
left a comment
There was a problem hiding this comment.
Hm, I'm not sure why I never reviewed this. Do you mind rebasing? Then I'll merge.
|
|
||
| /// Optional: Integer UNIX timestamp in milliseconds for when the access token should expire. | ||
| /// If not specified, the returned access token does not expire. | ||
| #[serde(default, skip_serializing_if = "Option::is_none")] |
Member
There was a problem hiding this comment.
serde(default) is implied for Option<_> typed fields.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
draft because I haven't tested it yet..