feat: Add finch check-update command#1562
Open
sondavidb wants to merge 1 commit intorunfinch:mainfrom
Open
Conversation
sondavidb
force-pushed
the
add-check-finch-update
branch
2 times, most recently
from
183709f to
9540a0f
Compare
Signed-off-by: Cartrius Phipps <cartrius@amazon.com> Signed-off-by: David Son <davbson@amazon.com>
sondavidb
force-pushed
the
add-check-finch-update
branch
from
9540a0f to
367b331
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Partial implementation of #1451
Description of changes:
In internal discussion we decided that the most sensible thing to do when shipping the update feature would be to split it into two sections — one section to check for updates, and another section to do the updating. This is the first of said parts.
Thanks @cartrius for spearheading the approach here!
Testing done:
make test-unitLicense Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.