Fix libdeflate feature selection#219
Merged
brainstorm merged 1 commit intorust-bio:masterfrom Jun 23, 2020
Merged
Conversation
Pull Request Test Coverage Report for Build 143906896
💛 - Coveralls |
Member
|
Good catch @juliangehring, thanks!
That should be tackled by libdeflate-sys itself afaik (it'll error out if not found or sth else is wrong)? Regardless, let's merge this PR, looks fine and seems to work now (local test), thanks again! |
Member
|
Oh, sorry, you meant testing as in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
libdeflatefeature (added in #189) isn't currently propagated and the feature gets silently ignored during build. Fixing the feature names and dependencies addresses this, and also ensures that the feature-specific tests are correctly ignored.If someone knows a good way to automatically test that the correct deflate library is included, I'd be happy to add this as well.