Skip to content

[client] Add chain tip query method to getdeploymentinfo RPC#480

Merged
tcharding merged 2 commits intorust-bitcoin:masterfrom
satsfy:fix-getdeploymentinfo
Feb 9, 2026
Merged

[client] Add chain tip query method to getdeploymentinfo RPC#480
tcharding merged 2 commits intorust-bitcoin:masterfrom
satsfy:fix-getdeploymentinfo

Conversation

@satsfy
Copy link
Copy Markdown
Contributor

@satsfy satsfy commented Jan 23, 2026

The getdeploymentinfo RPC blockhash argument is optional. If omitted, it queries the blockchain tip. This commit enables such RPC use case.

Partially fixes issue #474.

The getdeploymentinfo RPC blockhash argument is optional, if ommited
it queries the chain tip. This commit enables such RPC use case.
Copy link
Copy Markdown
Collaborator

@jamillambert jamillambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a second call in the existing test to use this new macro. Maybe with an assert that the returned data is for the current chain tip.

Ensures that getdeploymentinfo call without an explicit
blockhash returns the blockchain's tip block.
@satsfy satsfy force-pushed the fix-getdeploymentinfo branch from 9f9b92a to 8a3e44d Compare January 26, 2026 18:41
Copy link
Copy Markdown
Collaborator

@jamillambert jamillambert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8a3e44d

Comment thread integration_test/tests/blockchain.rs
Copy link
Copy Markdown
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 8a3e44d

@tcharding
Copy link
Copy Markdown
Member

Nice! Thanks for your work man.

@tcharding tcharding merged commit 2fc4833 into rust-bitcoin:master Feb 9, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants