Url follow ups
#491
Merged
Url follow ups
#491
+186
−281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnull
requested review from
TheBlueMatt,
oleonardolima and
tcharding
as code owners
... since it's not used.
.. instead of using an `std::io::Error`
tnull
force-pushed
the
2026-02-url-follow-ups
branch
from
e70138a to
5b1ab4c
Compare
Collaborator
Author
|
Rebased after #467 landed. |
tcharding
reviewed
Feb 4, 2026
| } | ||
| } | ||
|
|
||
| #[cfg(feature = "std")] |
tcharding
previously approved these changes
Feb 4, 2026
TheBlueMatt
reviewed
Feb 9, 2026
Member
TheBlueMatt
left a comment
TheBlueMatt
left a comment
There was a problem hiding this comment.
Can you address #467 (comment) ?
Also we currently still export a pub type URL = String; in src/request.rs. We can't drop it because we don't really want to bump the minor version, but it might be worth marking it deprecated?
Collaborator
Author
Done.
Now opened #497, opted not to mark deprecate to avoid annoying warnings until then. |
tnull
force-pushed
the
2026-02-url-follow-ups
branch
from
721e7ee to
1c71760
Compare
Collaborator
Author
|
Force-pushed with the following changes: > git diff-tree -U2 721e7ee2 fe729039
diff --git a/bitreq/fuzz/src/url_parse.rs b/bitreq/fuzz/src/url_parse.rs
index ae74a65d..722a3c3b 100644
--- a/bitreq/fuzz/src/url_parse.rs
+++ b/bitreq/fuzz/src/url_parse.rs
@@ -112,5 +112,6 @@ pub fn do_test(data: &[u8]) {
let mut url_clone = bitreq_url.clone();
url_clone.preserve_fragment_from(&url_with_frag);
- let _ = url_clone.fragment();
+ let new_frag = url_clone.fragment().unwrap();
+ assert_eq!(new_frag, "testfrag");
let _ = url_clone.as_str();
}
@@ -126,4 +127,5 @@ pub fn do_test(data: &[u8]) {
url_clone3.preserve_fragment_from(&url_no_frag);
let _ = url_clone3.as_str();
+ assert_eq!(url_clone2.fragment(), url_clone3.fragment());
}
} |
Add a `pub_if_fuzzing!` macro that conditionally sets method visibility to `pub` when `cfg(fuzzing)` is set, and `pub(crate)` otherwise. This allows the fuzzer to exercise these internal methods without exposing them in the public API. The fuzzer now tests both methods with various inputs including: - Arbitrary fuzz input as key/value pairs - Empty strings - Multiple sequential parameter appends - Fragment preservation from URLs with and without fragments Co-Authored-By: HAL 9000
…ator Replace the single-param `append_query_param` with `append_query_params` which accepts an `impl IntoIterator<Item = (String, String)>`, building the full serialization in one pass and calling `parse_inner` only once. This eliminates the `for` loop in `ParsedRequest::new`. Co-Authored-By: HAL 9000
tnull
force-pushed
the
2026-02-url-follow-ups
branch
from
1c71760 to
fe72903
Compare
Member
|
Oops looks like tests are failing now. |
Collaborator
Author
Fixed, was just a (pre-existing) overly strict test case. |
tnull
force-pushed
the
2026-02-url-follow-ups
branch
from
3a9ee19 to
f2a579f
Compare
Signed-off-by: Elias Rohrer <dev@tnull.de>
tnull
force-pushed
the
2026-02-url-follow-ups
branch
from
f2a579f to
8e8e408
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just addressing some non-blocking follow-ups from #467.
(hence currently also based on #467)