chore: update deployment workflows and add ECS action#3221
Merged
marcoieni merged 1 commit intorust-lang:mainfrom Mar 5, 2026
Merged
chore: update deployment workflows and add ECS action#3221marcoieni merged 1 commit intorust-lang:mainfrom
marcoieni merged 1 commit intorust-lang:mainfrom
Conversation
marcoieni
commented
Mar 4, 2026
GuillaumeGomez
approved these changes
Mar 4, 2026
Member
|
Looks good to me, thanks! Let's wait for @syphar to check as well before merging. |
syphar
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the deployment workflows by using latest best practices:
aws_secret_access_key(after this PR is merged, we can delete the AWS secrets from the GitHub Actions secrets)docker buildBased on https://github.com/rust-lang/bors/blob/main/.github/actions/deploy-ecs/action.yml
GitHub OIDC support was added in rust-lang/simpleinfra#1006
Since the docker containers are not used yet, it is safe to merge this PR and experiment with it 👍
Note on the github action
In the previous approach you were using a github action managed by the infra team, while now you don't anymore.
If there's a preference from various teams that the infra team creates a new shared github action (or update the existing one) we'll do it. But for now I would prefer to start with a local github action, so that we can iterate faster.
Other Docker images
Do we need to upload other images to ECR? If yes, we can do it in another PR.