archive-index-caches: just flush instead of sync_all, retry on corrupted files#3229
Merged
syphar merged 1 commit intorust-lang:mainfrom Mar 8, 2026
Merged
archive-index-caches: just flush instead of sync_all, retry on corrupted files#3229syphar merged 1 commit intorust-lang:mainfrom
syphar merged 1 commit intorust-lang:mainfrom
Conversation
eb3852a to
a1c0b65
Compare
GuillaumeGomez
approved these changes
Mar 8, 2026
a1c0b65 to
219b0b0
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking about the cache / boot problem, this is the next thing I want to try. it looks like we gain up t
Perhaps I was too pessimistic/conservative about the corrupted files we saw.
From what I see:
This will also hold true in case of the server process crashes.
Of course it won't in case of kernel crashes, but IMO that's fine for this use-case (locally cached files, the source of truth is on S3)
I added the rust-toolchain change because it lead to CI errors, somehow I think CI isn't using rust-toolchain.toml, need to check that separately.