Skip to content

archive-index-caches: just flush instead of sync_all, retry on corrupted files#3229

Merged
syphar merged 1 commit intorust-lang:mainfrom
syphar:reduce-archive-io
Mar 8, 2026
Merged

archive-index-caches: just flush instead of sync_all, retry on corrupted files#3229
syphar merged 1 commit intorust-lang:mainfrom
syphar:reduce-archive-io

Conversation

@syphar
Copy link
Member

@syphar syphar commented Mar 8, 2026

Thinking about the cache / boot problem, this is the next thing I want to try. it looks like we gain up t

Perhaps I was too pessimistic/conservative about the corrupted files we saw.

From what I see:

  • the flush will flush into disc caches
  • because of the rename, the download is atomic
  • so the server will either see the full download, or nothing.

This will also hold true in case of the server process crashes.

Of course it won't in case of kernel crashes, but IMO that's fine for this use-case (locally cached files, the source of truth is on S3)

I added the rust-toolchain change because it lead to CI errors, somehow I think CI isn't using rust-toolchain.toml, need to check that separately.

@syphar syphar self-assigned this Mar 8, 2026
@syphar syphar requested a review from a team as a code owner March 8, 2026 05:22
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Mar 8, 2026
@syphar syphar changed the title archive-index-caches: just flush instead of sync_all archive-index-caches: just flush instead of sync_all, retry on corrupted files Mar 8, 2026
@syphar syphar force-pushed the reduce-archive-io branch from eb3852a to a1c0b65 Compare March 8, 2026 06:23
@syphar syphar force-pushed the reduce-archive-io branch from a1c0b65 to 219b0b0 Compare March 8, 2026 10:25
@rustbot
Copy link
Collaborator

rustbot commented Mar 8, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@syphar syphar merged commit a68728e into rust-lang:main Mar 8, 2026
10 checks passed
@syphar syphar deleted the reduce-archive-io branch March 8, 2026 10:26
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Mar 8, 2026
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Mar 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants