Skip to content

Fix syntax highlighting for rust union keyword#3239

Merged
syphar merged 1 commit intorust-lang:mainfrom
GuillaumeGomez:union-keyword
Mar 10, 2026
Merged

Fix syntax highlighting for rust union keyword#3239
syphar merged 1 commit intorust-lang:mainfrom
GuillaumeGomez:union-keyword

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Mar 9, 2026

Fixes #3175.

@GuillaumeGomez GuillaumeGomez requested a review from a team as a code owner March 9, 2026 15:53
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Mar 9, 2026
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Mar 9, 2026

CI passed. :)

syphar
syphar reviewed Mar 10, 2026
View reviewed changes
Copy link
Member

@syphar syphar left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what I'm missing.

  • I imported the affected release so have the same source.
  • Then used your branch to run the webserver

But it still looks like this?

Image

View changes since this review

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Mar 10, 2026

Ah right, the regex was expecting a {, so if you have generics, it didn't work. Fixed it.

@syphar syphar merged commit 9008fb4 into rust-lang:main Mar 10, 2026
11 checks passed
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Mar 10, 2026
@GuillaumeGomez GuillaumeGomez deleted the union-keyword branch March 10, 2026 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@syphar syphar syphar approved these changes

Assignees

No one assigned

Labels

S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

union in source code isn't syntax-highlighted properly

2 participants

@GuillaumeGomez @syphar