Skip to content

Finish highjeans work #4989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chengr4 wants to merge 8 commits into
base: main
Choose a base branch
from
+16 −1
Open

Finish highjeans work #4989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9b2e0a9
Add correct darwin definition of pthread_t
highjeans Mar 16, 2025
d9e0263
Explicitly set "opaque_pthread_t" to be a struct rather than a type
highjeans Mar 17, 2025
2f307d9
Update symbols list
highjeans Mar 17, 2025
f65234c
Fix stylings
highjeans Mar 17, 2025
830afaf
Remove commented line
highjeans Mar 18, 2025
b7a0e64
Add #[non_exhaustive] attribute
chengr4 Feb 20, 2026
cef8e1b
Refactor pthread type definitions for better clarity and compatibility
chengr4 Feb 20, 2026
37afe49
styling
chengr4 Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions libc-test/semver/apple.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1786,6 +1786,7 @@ __PTHREAD_RWLOCKATTR_SIZE__
__PTHREAD_RWLOCK_SIZE__
__darwin_mcontext64
__error
_opaque_pthread_t
abs
acct
aio_cancel
Expand Down
16 changes: 15 additions & 1 deletion src/unix/bsd/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,21 @@ pub type useconds_t = u32;
pub type blkcnt_t = i64;
pub type socklen_t = u32;
pub type sa_family_t = u8;
pub type pthread_t = crate::uintptr_t;

cfg_if! {
if #[cfg(target_vendor = "apple")] {
extern_ty! {
pub enum _opaque_pthread_t {}
}

type __darwin_pthread_t = *mut _opaque_pthread_t;
pub type pthread_t = __darwin_pthread_t;
} else {
// FIXME(1.0): verify other BSDs? Glancing around, other BSDs also look like a pointer
pub type pthread_t = crate::uintptr_t;
}
}

pub type nfds_t = c_uint;
pub type regoff_t = off_t;

Expand Down