fix: Stale diagnostics when a custom check command is configured#21738
Open
Wilfred wants to merge 1 commit intorust-lang:masterfrom
Open
fix: Stale diagnostics when a custom check command is configured#21738Wilfred wants to merge 1 commit intorust-lang:masterfrom
Wilfred wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Wilfred
force-pushed
the
custom_check_command_stale_diagnostics
branch
from
350b5c3 to
6acb298
Compare
This comment has been minimized.
This comment has been minimized.
Wilfred
force-pushed
the
custom_check_command_stale_diagnostics
branch
from
6acb298 to
601f76c
Compare
This comment has been minimized.
This comment has been minimized.
Wilfred
force-pushed
the
custom_check_command_stale_diagnostics
branch
from
601f76c to
9b636b4
Compare
This comment has been minimized.
This comment has been minimized.
We can't use the flycheck scope, because that value varies depending on how the flycheck was triggered. See also rust-lang#21571, which was reverted due to issues with scope. Instead, treat empty diagnostics as a flycheck for the entire workspace, add comments explaining the JSON diagnostic format, and add an integration test.
Wilfred
force-pushed
the
custom_check_command_stale_diagnostics
branch
from
9b636b4 to
c6c2135
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
Author
|
Fixed the issue link to keep rustbot happy. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't use the flycheck scope, because that value varies depending on how the flycheck was triggered. See also #21571, which was reverted due to issues with scope.
Instead, treat empty diagnostics as a flycheck for the entire workspace, add comments explaining the JSON diagnostic format, and add an integration test.