feat: support inherent associated type paths#21758
Open
EienMiku wants to merge 2 commits intorust-lang:masterfrom
Open
feat: support inherent associated type paths#21758EienMiku wants to merge 2 commits intorust-lang:masterfrom
EienMiku wants to merge 2 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
EienMiku
force-pushed
the
fix-inherent-associated-type-type-paths
branch
2 times, most recently
from
6b29518 to
0bb621e
Compare
This comment has been minimized.
This comment has been minimized.
Add support for resolving paths for inherent associated types
EienMiku
force-pushed
the
fix-inherent-associated-type-type-paths
branch
from
0bb621e to
88e5890
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Extract the inherent impl type alias lookup into a shared `find_inherent_assoc_type()` helper, wire it into IDE path resolution
EienMiku
force-pushed
the
fix-inherent-associated-type-type-paths
branch
from
88e5890 to
f5214dc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16240
Add path lowering support for inherent associated types (e.g.
A::BwhereBis defined in an inherent impl,feature(inherent_associated_types)).Also added a test
inherent_associated_type_pathincrates\hir-ty\src\tests\traits.rs.