Migrate unqualify_method_call assist to SyntaxEditor#21774
Merged
A4-Tacks merged 1 commit intorust-lang:masterfrom Mar 7, 2026
Merged
Conversation
rustbot
added
the
S-waiting-on-review
A4-Tacks
approved these changes
Mar 7, 2026
| let make = SyntaxFactory::with_mappings(); | ||
| let mut editor = builder.make_editor(call.syntax()); | ||
|
|
||
| let new_arg_list = make.arg_list(args.args().skip(1)); |
Member
There was a problem hiding this comment.
This will lose the trivia between args, such as a multi line ArgList, but it is also imperfect before migration, it is okay
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #18285
Migrates the
unqualify_method_callassist handler from the oldted::/SourceChangeBuildertext-edit API to the newSyntaxEditor/SyntaxFactoryAPI.Changes
edit.delete,edit.insert,edit.replace) with node-based edits usingSyntaxEditorbuilder.make_mut()withbuilder.make_editor()insert_usewithinsert_use_with_editormake.expr_paren()andExprPrecedence::Postfixinstead of manual text-range insertionTesting
All 9 existing tests pass.