Migrate_____move_const_to_impl__assist to SyntaxEditor#21791
Open
akashchakrabortymsc-cmd wants to merge 1 commit intorust-lang:masterfrom
Open
Migrate_____move_const_to_impl__assist to SyntaxEditor#21791akashchakrabortymsc-cmd wants to merge 1 commit intorust-lang:masterfrom
akashchakrabortymsc-cmd wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
A4-Tacks
requested changes
Mar 10, 2026
| // If the moved const will be the first item of the impl, add a new line after that. | ||
| // | ||
| // We're assuming the code is formatted according to Rust's standard style guidelines | ||
| // (i.e. no empty lines between impl's `{` token and its first assoc item). |
| let const_ = const_.reset_indent(); | ||
| let const_ = const_.indent(indent); | ||
| let const_ = const_.indent_with_mapping(indent, &make); | ||
| builder.insert(insert_offset, format!("\n{indent}{const_}{fixup}")); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #18285
Changes
SyntaxFactory::with_mappings()to the assist closureindent()withindent_with_mapping(indent, &make)SyntaxEditorusingbuilder.make_editor()on theoriginal immutable node before
clone_for_update()editor.add_mappings(make.finish_with_mappings())builder.add_file_edits(ctx.vfs_file_id(), editor)All 12 existing tests pass