fix(explicit_counter_loop): suggest .take(n) for for _ in 0..n co…

[zayutaha]

When a loop variable is unused (for _ in 0..n) and the counter is being
incremented, Clippy previously suggested the generic zip-based rewrite.
This PR adds a more idiomatic .take(n) suggestion for the common case
where the range is half-open and starts at zero:

// before
for _ in 0..MAX {
    base += 1;
}

// suggested
for base in (100..).take(MAX)

Non-zero starts (5..MAX) and inclusive ranges (0..=MAX) are
explicitly excluded and fall through to the existing zip suggestion.
Both cases are covered by new UI tests.

changelog: [explicit_counter_loop]: suggest (init..).take(n) when loop variable is unused and range is 0..n

fixes #16642

[rustbot]

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: 7 candidates
• 7 candidates expanded to 7 candidates
• Random selection from Jarcho, dswij, llogiq, samueltardieu

[Jarcho]

Thank you.

View changes since this review