unnecessary_to_owned: don't lint if map key has extra indirection#16700
Open
zihan0822 wants to merge 1 commit intorust-lang:masterfrom
Open
unnecessary_to_owned: don't lint if map key has extra indirection#16700zihan0822 wants to merge 1 commit intorust-lang:masterfrom
unnecessary_to_owned: don't lint if map key has extra indirection#16700zihan0822 wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
Collaborator
|
r? @Jarcho rustbot has assigned @Jarcho. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Contributor
|
Can you just remove the special casing for map types and handle |
zihan0822
force-pushed
the
fix-unnecessary-to-owned
branch
3 times, most recently
from
688a2da to
0e41aa1
Compare
Contributor
Author
|
@rustbot ready |
Jarcho
reviewed
Mar 27, 2026
zihan0822
force-pushed
the
fix-unnecessary-to-owned
branch
from
0e41aa1 to
0046a4b
Compare
This comment has been minimized.
This comment has been minimized.
zihan0822
force-pushed
the
fix-unnecessary-to-owned
branch
from
0046a4b to
4aed26a
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Check to-owned-like method call receiver can satisfy borrow obligation. We further extend this lint to support non-std collection with getter-like apis. changelog: [`unnecessary_to_owned`]: don't lint if can't satisfy borrow obligation Signed-off-by: Zihan <zihanli0822@gmail.com>
zihan0822
force-pushed
the
fix-unnecessary-to-owned
branch
from
4aed26a to
cc046dd
Compare
Contributor
Author
|
updated and rebased |
Contributor
Author
|
ping @Jarcho |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #16693
changelog: [
unnecessary_to_owned]: don't lint if can't satisfy borrow obligation