Merged
Conversation
rustbot
added
the
S-waiting-on-review
Contributor
|
I think it would be fine to fail the build if there is a problem with links. That can be done by setting the environment variable |
Urgau
force-pushed
the
problem-matcher-mdbook
branch
from
a22c470 to
b4f9cf4
Compare
Urgau
changed the title
Member
Author
|
Adjusted the CI to deny the warnings. |
ehuss
approved these changes
Mar 1, 2026
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a problem matcher to GitHub can show the warnings.Would have avoided #1015.
Warning in CI: https://github.com/rust-lang/rust-forge/actions/runs/22433371335/job/64957025549#step:6:331
An alternative would be to deny all warnings. EDIT: Changed to that.
r? internal-sites