Add `#[define_opaques]` attribute and require it for all type-alias-impl-trait sites that register a hidden type by oli-obk · Pull Request #128440 · rust-lang/rust

oli-obk · 2024-07-31T15:36:40Z

Instead of relying on the signature of items to decide whether they are constraining an opaque type, the opaque types that the item constrains must be explicitly listed.

A previous version of this PR used an actual attribute, but had to keep the resolved DefIds in a side table.

Now we just lower to fields in the AST that have no surface syntax, instead a builtin attribute macro fills in those fields where applicable.

Note that for convenience referencing opaque types in associated types from associated methods on the same impl will not require an attribute. If that causes problems #[defines()] can be used to overwrite the default of searching for opaques in the signature.

One wart of this design is that closures and static items do not have generics. So since I stored the opaques in the generics of functions, consts and methods, I would need to add a custom field to closures and statics to track this information. During a T-types discussion we decided to just not do this for now.

fixes #131298

compiler/rustc_hir_analysis/src/collect/type_of/opaque.rs

bors · 2024-08-01T11:31:44Z

☔ The latest upstream changes (presumably #128481) made this pull request unmergeable. Please resolve the merge conflicts.

compiler/rustc_ast/src/attr/mod.rs

compiler/rustc_resolve/src/late.rs

compiler/rustc_passes/src/check_attr.rs

…ler-errors Avoid `opaque type not constrained` errors in the presence of other errors pulled out of rust-lang#128440 These errors carry no new information if the opaque type was actually used in a constraining (but erroneous) way somewhere.

Rollup merge of rust-lang#133850 - oli-obk:push-xryukktpyooq, r=compiler-errors Avoid `opaque type not constrained` errors in the presence of other errors pulled out of rust-lang#128440 These errors carry no new information if the opaque type was actually used in a constraining (but erroneous) way somewhere.

…nced

rust-timer · 2025-03-11T13:01:36Z

Finished benchmarking commit (b4867ea): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-1.6%, -0.2%]	56
Improvements ✅ (secondary)	-0.6%	[-1.5%, -0.4%]	4
All ❌✅ (primary)	-0.5%	[-1.6%, -0.2%]	56

Max RSS (memory usage)

Results (primary 1.4%, secondary -3.7%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.4%	[1.4%, 1.4%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.7%	[-4.4%, -3.0%]	2
All ❌✅ (primary)	1.4%	[1.4%, 1.4%]	1

Cycles

Results (primary -1.1%, secondary -2.4%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[2.7%, 2.7%]	1
Improvements ✅ (primary)	-1.1%	[-1.2%, -0.9%]	2
Improvements ✅ (secondary)	-4.9%	[-5.2%, -4.6%]	2
All ❌✅ (primary)	-1.1%	[-1.2%, -0.9%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 782.387s -> 780.697s (-0.22%)
Artifact size: 365.21 MiB -> 365.23 MiB (0.01%)

oli-obk · 2025-03-11T13:06:05Z

Yay

oli-obk · 2025-03-11T13:19:35Z

@bors r=lcnr

bors · 2025-03-11T13:19:38Z

📌 Commit 69a1bb8 has been approved by lcnr

It is now in the queue for this repository.

bors · 2025-03-11T18:13:36Z

⌛ Testing commit 69a1bb8 with merge 6650252...

bors · 2025-03-11T21:16:10Z

☀️ Test successful - checks-actions
Approved by: lcnr
Pushing 6650252 to master...

github-actions · 2025-03-11T21:17:53Z

Post-merge analysis result

Test differences

x86_64-gnu-nopt
- compiler/rustc_ast_pretty/src/pprust/state.rs - pprust::state::State<'a>::print_let (line 1448): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_impl (line 560): [missing] -> ignore
- compiler/rustc_resolve/src/late.rs - late::LateResolutionVisitor<'a,'ast,'ra,'tcx>::compute_and_check_or_pat_binding_map (line 3690): [missing] -> pass
- compiler/rustc_hir/src/hir.rs - hir::LocalSource::AsyncFn (line 2732): [missing] -> ignore
- compiler/rustc_hir/src/hir.rs - hir::Node<'hir>::ident (line 4520): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_foreign_mod (line 1213): [missing] -> ignore
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/generics.rs: [missing] -> pass
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_extern_crate (line 1157): [missing] -> ignore
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/foreign_type.rs: [missing] -> pass
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/non_type.rs: [missing] -> pass
- (and 23 additional testss)
x86_64-gnu-llvm-19-3
- compiler/rustc_hir/src/hir.rs - hir::LocalSource::AsyncFn (line 2732): [missing] -> ignore
- compiler/rustc_hir/src/hir.rs - hir::PatKind::Slice (line 1744): [missing] -> ignore
- compiler/rustc_hir/src/hir.rs - hir::Node<'hir>::ident (line 4520): [missing] -> ignore
- [ui] tests/ui/type-alias-impl-trait/path_resolution_taint.rs: [missing] -> pass
- compiler/rustc_resolve/src/late.rs - late::LateResolutionVisitor<'a,'ast,'ra,'tcx>::compute_and_check_or_pat_binding_map (line 3690): [missing] -> pass
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/non_type.rs: [missing] -> pass
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/generics.rs: [missing] -> pass
- compiler/rustc_resolve/src/late.rs - late::LateResolutionVisitor<'a,'ast,'ra,'tcx>::compute_and_check_binding_map (line 3624): [missing] -> pass
- compiler/rustc_ast_pretty/src/pprust/state.rs - pprust::state::State<'a>::print_let (line 1437): [missing] -> ignore
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/no_opaque.rs: [missing] -> pass
- (and 23 additional testss)
x86_64-gnu
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_extern_crate (line 1157): [missing] -> ignore
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/no_opaque.rs: [missing] -> pass
- compiler/rustc_ast_pretty/src/pprust/state.rs - pprust::state::State<'a>::print_let (line 1448): [missing] -> ignore
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/missing_parens.rs: [missing] -> pass
- compiler/rustc_hir/src/hir.rs - hir::Node<'hir>::ident (line 4520): [missing] -> ignore
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/non_type.rs: [missing] -> pass
- compiler/rustc_hir/src/hir.rs - hir::LocalSource::AsyncFn (line 2732): [missing] -> ignore
- compiler/rustc_ast_pretty/src/pprust/state.rs - pprust::state::State<'a>::print_let (line 1437): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_foreign_mod (line 1213): [missing] -> ignore
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/invalid_path.rs: [missing] -> pass
- (and 23 additional testss)
x86_64-gnu-llvm-18-3
- compiler/rustc_resolve/src/late.rs - late::LateResolutionVisitor<'a,'ast,'ra,'tcx>::compute_and_check_or_pat_binding_map (line 3690): [missing] -> pass
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_extern_crate (line 1157): [missing] -> ignore
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/no_opaque.rs: [missing] -> pass
- compiler/rustc_hir/src/hir.rs - hir::LocalSource::AsyncFn (line 2732): [missing] -> ignore
- compiler/rustc_hir/src/hir.rs - hir::Body (line 1862): [missing] -> pass
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_foreign_mod (line 1213): [missing] -> ignore
- [ui] tests/ui/type-alias-impl-trait/path_resolution_taint.rs: [missing] -> pass
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/missing_parens.rs: [missing] -> pass
- compiler/rustc_hir/src/hir.rs - hir::PatKind::Slice (line 1744): [missing] -> ignore
- compiler/rustc_resolve/src/late.rs - late::LateResolutionVisitor<'a,'ast,'ra,'tcx>::compute_and_check_binding_map (line 3624): [missing] -> pass
- (and 23 additional testss)
x86_64-gnu-stable
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/no_opaque.rs: [missing] -> pass
- compiler/rustc_resolve/src/late.rs - late::LateResolutionVisitor<'a,'ast,'ra,'tcx>::compute_and_check_binding_map (line 3624): [missing] -> pass
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/invalid_path.rs: [missing] -> pass
- compiler/rustc_hir/src/hir.rs - hir::Node<'hir>::ident (line 4520): [missing] -> ignore
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/generics.rs: [missing] -> pass
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_extern_crate (line 1157): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_foreign_mod (line 1213): [missing] -> ignore
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/non_type.rs: [missing] -> pass
- [ui] tests/ui/type-alias-impl-trait/path_resolution_taint.rs: [missing] -> pass
- compiler/rustc_ast_pretty/src/pprust/state.rs - pprust::state::State<'a>::print_let (line 1437): [missing] -> ignore
- (and 23 additional testss)
aarch64-apple
- compiler/rustc_hir/src/hir.rs - hir::Body (line 1862): [missing] -> pass
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/non_type.rs: [missing] -> pass
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/no_opaque.rs: [missing] -> pass
- compiler/rustc_hir/src/hir.rs - hir::PatKind::Slice (line 1744): [missing] -> ignore
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/missing_parens.rs: [missing] -> pass
- compiler/rustc_hir/src/hir.rs - hir::Node<'hir>::ident (line 4520): [missing] -> ignore
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/invalid_path.rs: [missing] -> pass
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_foreign_mod (line 1213): [missing] -> ignore
- compiler/rustc_resolve/src/late.rs - late::LateResolutionVisitor<'a,'ast,'ra,'tcx>::compute_and_check_or_pat_binding_map (line 3690): [missing] -> pass
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_impl (line 560): [missing] -> ignore
- (and 23 additional testss)
aarch64-gnu
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_extern_crate (line 1157): [missing] -> ignore
- compiler/rustc_hir/src/hir.rs - hir::PatKind::Slice (line 1744): [missing] -> ignore
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/foreign_type.rs: [missing] -> pass
- compiler/rustc_resolve/src/late.rs - late::LateResolutionVisitor<'a,'ast,'ra,'tcx>::compute_and_check_or_pat_binding_map (line 3690): [missing] -> pass
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/no_opaque.rs: [missing] -> pass
- [ui] tests/ui/type-alias-impl-trait/define_opaques_attr/invalid_path.rs: [missing] -> pass
- compiler/rustc_hir/src/hir.rs - hir::Node<'hir>::ident (line 4520): [missing] -> ignore
- compiler/rustc_ast_pretty/src/pprust/state.rs - pprust::state::State<'a>::print_let (line 1437): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_impl (line 560): [missing] -> ignore
- [ui] tests/ui/type-alias-impl-trait/path_resolution_taint.rs: [missing] -> pass
- (and 23 additional testss)
x86_64-apple-1
- compiler/rustc_ast_pretty/src/pprust/state.rs - pprust::state::State<'a>::print_let (line 1448): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_extern_crate (line 1157): [missing] -> ignore
- compiler/rustc_resolve/src/late.rs - late::LateResolutionVisitor<'a,'ast,'ra,'tcx>::compute_and_check_or_pat_binding_map (line 3690): [missing] -> pass
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_foreign_mod (line 1213): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_impl (line 560): [missing] -> ignore
- compiler/rustc_resolve/src/late.rs - late::LateResolutionVisitor<'a,'ast,'ra,'tcx>::compute_and_check_binding_map (line 3624): [missing] -> pass
- compiler/rustc_hir/src/hir.rs - hir::LocalSource::AsyncFn (line 2732): [missing] -> ignore
- compiler/rustc_ast_pretty/src/pprust/state.rs - pprust::state::State<'a>::print_let (line 1437): [missing] -> ignore
- compiler/rustc_hir/src/hir.rs - hir::Body (line 1862): [missing] -> pass
- compiler/rustc_hir/src/hir.rs - hir::Node<'hir>::ident (line 4520): [missing] -> ignore
- (and 14 additional testss)
i686-msvc-2
- compiler/rustc_hir/src/hir.rs - hir::Node<'hir>::ident (line 4520): [missing] -> ignore
- compiler/rustc_resolve/src/late.rs - late::LateResolutionVisitor<'a,'ast,'ra,'tcx>::compute_and_check_binding_map (line 3624): [missing] -> pass
- compiler/rustc_ast_pretty/src/pprust/state.rs - pprust::state::State<'a>::print_let (line 1437): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_impl (line 560): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_extern_crate (line 1157): [missing] -> ignore
- compiler/rustc_hir/src/hir.rs - hir::PatKind::Slice (line 1744): [missing] -> ignore
- compiler/rustc_ast_pretty/src/pprust/state.rs - pprust::state::State<'a>::print_let (line 1448): [missing] -> ignore
- compiler/rustc_hir/src/hir.rs - hir::LocalSource::AsyncFn (line 2732): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_foreign_mod (line 1213): [missing] -> ignore
- compiler/rustc_hir/src/hir.rs - hir::Body (line 1862): [missing] -> pass
- (and 13 additional testss)
i686-mingw-3
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_impl (line 560): [missing] -> ignore
- compiler/rustc_hir/src/hir.rs - hir::LocalSource::AsyncFn (line 2732): [missing] -> ignore
- compiler/rustc_hir/src/hir.rs - hir::PatKind::Slice (line 1744): [missing] -> ignore
- compiler/rustc_ast_pretty/src/pprust/state.rs - pprust::state::State<'a>::print_let (line 1437): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_extern_crate (line 1157): [missing] -> ignore
- compiler/rustc_resolve/src/late.rs - late::LateResolutionVisitor<'a,'ast,'ra,'tcx>::compute_and_check_binding_map (line 3624): [missing] -> pass
- compiler/rustc_hir/src/hir.rs - hir::Body (line 1862): [missing] -> pass
- compiler/rustc_hir/src/hir.rs - hir::Node<'hir>::ident (line 4520): [missing] -> ignore
- compiler/rustc_ast_pretty/src/pprust/state.rs - pprust::state::State<'a>::print_let (line 1448): [missing] -> ignore
- compiler/rustc_parse/src/parser/item.rs - parser::item::Parser<'a>::parse_item_foreign_mod (line 1213): [missing] -> ignore
- (and 13 additional testss)

(and 19 additional diffs)

rust-timer · 2025-03-11T22:53:20Z

Finished benchmarking commit (6650252): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-1.6%, -0.2%]	58
Improvements ✅ (secondary)	-0.4%	[-0.4%, -0.4%]	3
All ❌✅ (primary)	-0.5%	[-1.6%, -0.2%]	58

Max RSS (memory usage)

Results (primary -1.9%, secondary 2.8%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[1.2%, 4.3%]	5
Improvements ✅ (primary)	-1.9%	[-3.2%, -0.8%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.9%	[-3.2%, -0.8%]	3

Cycles

Results (primary -1.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-1.4%, -0.8%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.1%	[-1.4%, -0.8%]	3

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 781.59s -> 780.09s (-0.19%)
Artifact size: 365.22 MiB -> 365.26 MiB (0.01%)

rustbot assigned chenyukang Jul 31, 2024

oli-obk commented Jul 31, 2024

View reviewed changes

compiler/rustc_hir_analysis/src/collect/type_of/opaque.rs Outdated Show resolved Hide resolved

oli-obk unassigned chenyukang Jul 31, 2024

oli-obk added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 31, 2024

This comment has been minimized.

Sign in to view

oli-obk mentioned this pull request Jul 31, 2024

TAIT feature is broken #126387

Closed

petrochenkov self-assigned this Jul 31, 2024

petrochenkov added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 31, 2024

oli-obk mentioned this pull request Aug 1, 2024

Associated type position impl trait rust-lang/rust-project-goals#103

Closed

3 tasks

petrochenkov reviewed Aug 14, 2024

View reviewed changes

compiler/rustc_ast/src/attr/mod.rs Show resolved Hide resolved

compiler/rustc_resolve/src/late.rs Outdated Show resolved Hide resolved

compiler/rustc_resolve/src/late.rs Outdated Show resolved Hide resolved

compiler/rustc_passes/src/check_attr.rs Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 14, 2024

petrochenkov removed their assignment Aug 14, 2024

This comment was marked as resolved.

Sign in to view

traviscross added the F-type_alias_impl_trait `#[feature(type_alias_impl_trait)]` label Aug 23, 2024

xxchan mentioned this pull request Sep 10, 2024

refactor: bump toolchain to 2024-07-19 risingwavelabs/risingwave#18470

Merged

9 tasks

oli-obk mentioned this pull request Dec 4, 2024

Avoid opaque type not constrained errors in the presence of other errors #133850

Merged

oli-obk force-pushed the defines branch from d6e4776 to cb85e75 Compare December 10, 2024 09:33

rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Dec 10, 2024

oli-obk force-pushed the defines branch from cb85e75 to 1907ecc Compare December 18, 2024 10:13

This comment has been minimized.

Sign in to view

This comment was marked as resolved.

Sign in to view

oli-obk mentioned this pull request Jan 8, 2025

Stabilize associated type position impl Trait (ATPIT) #120700

Open

3 tasks

oli-obk force-pushed the defines branch from aee2da5 to 39a55ce Compare March 11, 2025 11:46

This comment has been minimized.

Sign in to view

oli-obk and others added 4 commits March 11, 2025 12:05

Implement #[define_opaque] attribute for functions.

cb4751d

Test invalid define_opaques attributes

3e4e65e

Keep items around even if builtin macros on them fail to parse

43e3926

Error on define_opaques entries without any opaques actually refere…

69a1bb8

…nced

oli-obk force-pushed the defines branch from 39a55ce to 69a1bb8 Compare March 11, 2025 12:05

rustbot added A-tidy Area: The tidy tool T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Mar 11, 2025

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Mar 11, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 11, 2025

bors mentioned this pull request Mar 11, 2025

Detect struct construction with private field in field with default #135846

Merged

This was referenced Mar 12, 2025

TAIT defining scope options #107645

Closed

TAIT decision on whether nested inner items may define #117860

Closed

Dirbaio mentioned this pull request Mar 13, 2025

make_static!() does not work anymore since rustc nightly-2024-06-13 embassy-rs/static-cell#16

Closed

oli-obk mentioned this pull request Mar 14, 2025

Add a per-item query just for define_opaque attributes #138500

Closed

kpreid mentioned this pull request Apr 5, 2025

TAIT: typed patterns don't count as defining uses #113596

Open

matthiaskrgr mentioned this pull request May 23, 2025

ICE: opaque_types_defined_by not defined for synthetic mir body #141466

Closed

oli-obk mentioned this pull request Aug 12, 2025

Can't define TAIT inside another function #145296

Open

WaffleLapkin mentioned this pull request Nov 5, 2025

Closure-like blocks capture all generic type and const parameters #65442

Open

Uh oh!

Conversation

oli-obk commented Jul 31, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

bors commented Aug 1, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

This comment was marked as resolved.

This comment has been minimized.

This comment was marked as resolved.

This comment has been minimized.

rust-timer commented Mar 11, 2025

Overall result: ✅ improvements - no action needed

Uh oh!

oli-obk commented Mar 11, 2025

Uh oh!

oli-obk commented Mar 11, 2025

Uh oh!

bors commented Mar 11, 2025

Uh oh!

bors commented Mar 11, 2025

Uh oh!

bors commented Mar 11, 2025

Uh oh!

github-actions bot commented Mar 11, 2025

Test differences

Uh oh!

rust-timer commented Mar 11, 2025

Overall result: ✅ improvements - no action needed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

oli-obk commented Jul 31, 2024 •

edited

Loading