Implement IntoIterator for [&[mut]] Box<[T; N], A>#134021
Open
WaffleLapkin wants to merge 5 commits intorust-lang:mainfrom
Open
Implement IntoIterator for [&[mut]] Box<[T; N], A>#134021WaffleLapkin wants to merge 5 commits intorust-lang:mainfrom
IntoIterator for [&[mut]] Box<[T; N], A>#134021WaffleLapkin wants to merge 5 commits intorust-lang:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
6f3a44b to
576e704
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
|
☔ The latest upstream changes (presumably #136572) made this pull request unmergeable. Please resolve the merge conflicts. |
scottmcm
reviewed
Feb 24, 2025
Member
Author
|
@scottmcm anything I can do to move this forward? |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Mark-Simulacrum
requested changes
Feb 14, 2026
6bcd9c3 to
72ea626
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
72ea626 to
366152c
Compare
This comment has been minimized.
This comment has been minimized.
33ce55c to
a26c96f
Compare
Member
Author
|
@Mark-Simulacrum I don't think this requires edition handling or FCP, as per the FCP on the previous attempt at doing this:
@rustbot review |
…>` and `[T; N]` They'll be needed for `IntoIterator` impls.
a26c96f to
91e8eb2
Compare
Member
Author
|
I've also removed the complicated unsafe impl for now, making the |
This comment has been minimized.
This comment has been minimized.
Note: this removes warnings, as this breakage was deemed acceptable, see <rust-lang#124108 (comment)>
91e8eb2 to
f65b35f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revival of #124108
I copied the
<[T; N] as IntoIterator>::Iter's impl, but this does not seem satisfying:IndexRangepublicr? @scottmcm
maybe you have better implementation ideas.