trait_sel: add builtin impl for PointeeSized#142663
trait_sel: add builtin impl for PointeeSized#142663davidtwco wants to merge 1 commit intorust-lang:masterfrom
PointeeSized#142663Conversation
During review of rust-lang#137944, we thought we could remove the builtin impl of `PointeeSized` as it was removed during lowering, but users can still write `dyn PointeeSized` and so we need the builtin impl.
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
|
|
Do we even want to allow I'd somewhat opt to just rejecting |
I do agree. I don't think we should only land something like #142661 which can report things like I think it would make sense to add a separate error somewhere for |
|
Closing in favour of #143104 |
…sized-deny, r=compiler-errors hir_analysis: prohibit `dyn PointeeSized` Fixes rust-lang#142652 Supersedes rust-lang#142663 `dyn PointeeSized` is nonsensical as a `dyn PointeeSized` needs to be `MetaSized`, so lets reject it to avoid hitting code paths that expect a builtin impl for `PointeeSized` r? `@compiler-errors`
Rollup merge of #143104 - davidtwco:issue-142652-dyn-pointeesized-deny, r=compiler-errors hir_analysis: prohibit `dyn PointeeSized` Fixes #142652 Supersedes #142663 `dyn PointeeSized` is nonsensical as a `dyn PointeeSized` needs to be `MetaSized`, so lets reject it to avoid hitting code paths that expect a builtin impl for `PointeeSized` r? `@compiler-errors`
…y, r=compiler-errors hir_analysis: prohibit `dyn PointeeSized` Fixes rust-lang/rust#142652 Supersedes rust-lang/rust#142663 `dyn PointeeSized` is nonsensical as a `dyn PointeeSized` needs to be `MetaSized`, so lets reject it to avoid hitting code paths that expect a builtin impl for `PointeeSized` r? `@compiler-errors`
4 participants
Fixes #142652
Supersedes #142661
During review of #137944, we thought we could remove the builtin impl of
PointeeSizedas it was removed during lowering, but users can still writedyn PointeeSizedand so we need the builtin impl.r? @oli-obk