Deduplicated float tests and unified in floats/mod.rs

[xonx4l]

In this PR Float tests are deduplicated and are unified in floats/mod.rs, as discussed in #141726.

The moved float tests are:

-> test_powf
-> test_exp
-> test_exp2
-> test_ln
-> test_log_generic
-> test_log2
-> test_log10
-> test_asinh
-> test_acosh
-> test_atanh
-> test_gamma
-> test_ln_gamma

Closes: #141726

r? tgross35

[rustbot]

tgross35 is currently at their maximum review capacity.
They may take a while to respond.

[xonx4l]

Any update @bjorn3 ?

[bjorn3]

CI is still failing.

[xonx4l]

CI is still failing.

ok let me fix .

[rustbot]

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

[LorrensP-2158466]

This test here for f128 will fail because the precision is much higher, if you look at the original test, the expected value is much more precise than what you have written:

assert_approx_eq!(2.3f128.log(3.5), 0.66485771361478710036766645911922010272, TOL);

When testing higher precision floats, you need much more precise expected values or the tests will fail, as they do now. In Miri, this is even more strict.

If you look at the source of f16 constants, they use much more digits after the decimal point than needed:

pub const PI: f16 = 3.14159265358979323846264338327950288_f16;

So you should probably do that as well.

[xonx4l]

Okay it makes sense . Thanks

[tgross35]

Thank you for the final cleanup here. Until CI is fixed,
@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.

[xonx4l]

Thank you for the final cleanup here. Until CI is fixed, @rustbot author

Will finish this as soon as possible . A bit busy these days.

[rust-bors]

💔 Test for 7250dcf failed: CI. Failed job:

• try - aarch64-apple (web logs, enhanced plaintext logs)

[xonx4l]

@tgross35 what you suggest for these macOS linker errors?

[tgross35]

Sorry, I've been a bit busy. It looks like 451738f got wiped away, could you cherry pick it back? Those look like the right kind of failures.

(maybe you know already but in case you don't - if you add .patch to a github commit page then it gives you the plaintext patch, so you can run curl https://github.com/rust-lang/rust/commit/451738f6b0bc30d9a77be5ae304bbc5cdd71caa2.patch | git am to easily pick a commit)

[xonx4l]

Yeah not a problem I myself was busy and I will cherry-pick that commit asap.

[tgross35]

You'll need to add the #![feature] to the coretests as suggested above, that's a new associated constant.

[tgross35]

@bors try jobs=aarch64-apple,x86_64-mingw-1

[rust-bors]

💔 Test for 014baa1 failed: CI. Failed job:

• try - aarch64-apple (web logs, enhanced plaintext logs)

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[xonx4l]

@tgross35 If everything looks good you can rerun bors . I hope it passes this time .

[tgross35]

@bors try jobs=aarch64-apple,x86_64-mingw-1

[rust-bors]

☀️ Try build successful (CI)
Build commit: b9d8d0c (b9d8d0ce4b09c9ce57f304ee5fe47a428ccd875e, parent: 139651428df86cf88443295542c12ea617cbb587)

[tgross35]

Let's try again! Thanks for the updates.
@bors r+ rollup=iffy

View changes since this review

[rust-bors]

📌 Commit 8379475 has been approved by tgross35

It is now in the queue for this repository.

[xonx4l]

I really wanted to thanks @tgross35 for holding on this for so long and showing me direction whenever needed and also @bjorn3 for his help. (P.s. I am sure that I am not forgetting how to patch and rebase ever in this lifetime thanks to this Pr)

[tgross35]

We’re always happy to help, and we appreciate the effort :)